Re: [PATCH v2 2/5] accel/ethosu: fix scheduler and IRQ lifetime

Rob Herring <[email protected]>
Newsgroups org.freedesktop.lists.dri-devel
Message-ID <[email protected]>
On Fri, Jul 17, 2026 at 02:11:42PM +0800, GuoHan Zhao wrote:
> ethosu_job_init() requests the managed IRQ before initializing the DRM
> scheduler. If drm_sched_init() fails, the error path calls drm_sched_fini()
> on a partially initialized scheduler. The IRQ also remains registered until
> devres cleanup after normal or probe-error paths destroy the scheduler.
> 
> Initialize the scheduler before requesting the IRQ. Scheduler setup failure
> then needs no teardown, while IRQ setup failure can tear down a valid
> scheduler. Free the IRQ explicitly before drm_sched_fini() to prevent
> interrupt handlers from accessing scheduler state during teardown.

I don't think there's an actual issue here. The interrupt is never going 
to fire unless probe successfully completes because we reset the h/w and 
the interrupt only fires if we schedule something on it.

Rob
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.