Re: [PATCH v11 2/2] drm/bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.freedesktop.lists.dri-devel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 25/08/2026 16:09, Luca Ceresoli wrote:
>
>> +static struct i2c_device_id lt9611c_id[] = {
>> + { "lontium,lt9611c", (kernel_ulong_t)<9611c_chip_data[CHIP_LT9611C] },
>> + { "lontium,lt9611ex", (kernel_ulong_t)<9611c_chip_data[CHIP_LT9611EX] },
>> + { "lontium,lt9611uxd", (kernel_ulong_t)<9611c_chip_data[CHIP_LT9611UXD] },
>
> AFAIK there should be no vendor prefix for the i2c_device_id. Have a look
> at the docs and other drivers for the best practice.
This is because of bugs in the driver, which I reported at v6. Code had
NULL ptr and to solve it, instead of fixing it, Lontium added such prefixes.
Obviously this is a no-go and they MUST fix the null pointer in the
first place.
Best regards,
Krzysztof