Re: [PATCH 2/4] drm/i915/fbc: refactor maximum plane size handling for fbc

On Fri, 2026-07-17 at 01:59 +0300, Vinod Govindapillai wrote:
> Restrictions to enable FBC based on fixed plane width and height
> have been improving in newer platforms and eventualy may allow
> the maximum plane size as per the platform resolution support.
> Update the function which checks such a size restriction to have
> the possibility to get the maximum plane width and height
> compared rather than the hard coded values.
> 
> Signed-off-by: Vinod Govindapillai <[email protected]>

I don't see any benefit having this as a separate patch. You could just
fine squash this into patch 3/4.

BR,
Jouni Högander

> ---
>  drivers/gpu/drm/i915/display/intel_fbc.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c
> b/drivers/gpu/drm/i915/display/intel_fbc.c
> index a7d02dd6ca96..78228a5e765f 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1315,9 +1315,11 @@ static bool intel_fbc_surface_size_ok(const
> struct intel_plane_state *plane_stat
>  	return effective_w <= max_w && effective_h <= max_h;
>  }
>  
> -static void intel_fbc_max_plane_size(struct intel_display *display,
> +static void intel_fbc_max_plane_size(const struct intel_plane_state
> *plane_state,
>  				     unsigned int *w, unsigned int
> *h)
>  {
> +	struct intel_display *display =
> to_intel_display(plane_state);
> +
>  	if (DISPLAY_VER(display) >= 10) {
>  		*w = 5120;
>  		*h = 4096;
> @@ -1335,10 +1337,9 @@ static void intel_fbc_max_plane_size(struct
> intel_display *display,
>  
>  static bool intel_fbc_plane_size_valid(const struct
> intel_plane_state *plane_state)
>  {
> -	struct intel_display *display =
> to_intel_display(plane_state);
>  	unsigned int w, h, max_w, max_h;
>  
> -	intel_fbc_max_plane_size(display, &max_w, &max_h);
> +	intel_fbc_max_plane_size(plane_state, &max_w, &max_h);
>  
>  	w = drm_rect_width(&plane_state->uapi.src) >> 16;
>  	h = drm_rect_height(&plane_state->uapi.src) >> 16;