RE: [PATCH 01/14] drm/i915/hdmi: Use correct type for output_format parameter

"Kandpal, Suraj" <[email protected]> Mon, 3 Aug 2026 04:32:42 +0000
Newsgroups org.freedesktop.lists.intel-gfx,org.freedesktop.lists.intel-xe
Message-ID <DS4PPFE901A304F3721E80E96C9750C2F1AE3D52@DS4PPFE901A304F.namprd11.prod.outlook.com>
> Subject: [PATCH 01/14] drm/i915/hdmi: Use correct type for output_format
> parameter
>=20
> Correct the data-type of the argument output_format to enum, for the func=
tion
> intel_hdmi_dsc_get_bpp().
>=20

This should have a fixes tag

Otherwise LGTM,
Reviewed-by: Suraj Kandpal <[email protected]>

> Signed-off-by: Ankit Nautiyal <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++--
> drivers/gpu/drm/i915/display/intel_hdmi.h | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
> b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 8a019d3574df..9af0f3aba0fc 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -3338,8 +3338,8 @@ intel_hdmi_dsc_get_num_slices(const struct
> intel_crtc_state *crtc_state,
>   */
>  int
>  intel_hdmi_dsc_get_bpp(int src_fractional_bpp, int slice_width, int num_=
slices,
> -		       int output_format, bool hdmi_all_bpp,
> -		       int hdmi_max_chunk_bytes)
> +		       enum intel_output_format output_format,
> +		       bool hdmi_all_bpp, int hdmi_max_chunk_bytes)
>  {
>  	int max_dsc_bpp, min_dsc_bpp;
>  	int target_bytes;
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.h
> b/drivers/gpu/drm/i915/display/intel_hdmi.h
> index 0fa3661568e8..fb950fdd0e7a 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.h
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.h
> @@ -54,8 +54,8 @@ bool intel_hdmi_bpc_possible(const struct
> intel_crtc_state *crtc_state,
>  			     int bpc, bool has_hdmi_sink);
>  int intel_hdmi_tmds_clock(int clock, int bpc, enum intel_output_format
> sink_format);  int intel_hdmi_dsc_get_bpp(int src_fractional_bpp, int
> slice_width,
> -			   int num_slices, int output_format, bool
> hdmi_all_bpp,
> -			   int hdmi_max_chunk_bytes);
> +			   int num_slices, enum intel_output_format
> output_format,
> +			   bool hdmi_all_bpp, int hdmi_max_chunk_bytes);
>  int intel_hdmi_dsc_get_num_slices(const struct intel_crtc_state *crtc_st=
ate,
>  				  int src_max_slices, int src_max_slice_width,
>  				  int hdmi_max_slices, int hdmi_throughput);
> --
> 2.50.1