Re: [PATCH v3 2/2] drm/xe/oa: Extend OAM unit hwe assignment for new dGfx

Umesh Nerlige Ramappa <[email protected]>
Newsgroups org.freedesktop.lists.intel-xe
Message-ID <amp8AwEXp6/[email protected]>
On Mon, Jul 27, 2026 at 10:27:12AM -0700, Ashutosh Dixit wrote:
>dGfx vecs hwe's for media version 35.00 and later follow the same
>assignment to OAM units as vcs engines.
>
>Bspec: 77977
>
>Cc: Umesh Nerlige Ramappa <[email protected]>
>Signed-off-by: Ashutosh Dixit <[email protected]>

LGTM

Reviewed-by: Umesh Nerlige Ramappa <[email protected]>

Thanks,
Umesh
>---
> drivers/gpu/drm/xe/xe_oa.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
>index 21dbd98b2521f..56d51c40093df 100644
>--- a/drivers/gpu/drm/xe/xe_oa.c
>+++ b/drivers/gpu/drm/xe/xe_oa.c
>@@ -2624,10 +2624,11 @@ static u32 __hwe_oam_unit(struct xe_hw_engine *hwe)
> 		return XE_OA_UNIT_INVALID;
> 	else if (!IS_DGFX(gt_to_xe(hwe->gt)))
> 		return XE_OAM_UNIT_SCMI_0;
>-	else if (hwe->class == XE_ENGINE_CLASS_VIDEO_DECODE)
>-		return (hwe->instance / 2 & 0x1) + 1;
>-	else if (hwe->class == XE_ENGINE_CLASS_VIDEO_ENHANCE)
>+	else if (hwe->class == XE_ENGINE_CLASS_VIDEO_ENHANCE &&
>+		 MEDIA_VERx100(gt_to_xe(hwe->gt)) < 3500)
> 		return (hwe->instance & 0x1) + 1;
>+	else
>+		return (hwe->instance / 2 & 0x1) + 1;
>
> 	return XE_OA_UNIT_INVALID;
> }
>-- 
>2.54.0
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.