Re: [PATCH] drm/xe/ras: Split RAS init into xe_ras_init_early and xe_ras_init

On Thu, Jul 30, 2026 at 10:57:51AM +0200, Raag Jadav wrote:
> On Thu, Jul 30, 2026 at 12:24:31PM +0530, Mallesh Koujalagi wrote:
> > xe_ras_init() was doing two unrelated things: setting up internal
> > bookkeeping needed before interrupts start, and querying firmware
> > errors that can only be done safely after the device is registered.
> > 
> > Split it into two functions with clear responsibilities:
> > 
> > - xe_ras_init_early(): runs early, before interrupts are enabled.
> > 
> > - xe_ras_init(): runs after the device is registered.
> 
> Why not just xe_ras_process_errors() after drm_dev_register() and keep
> the rest as is?
> 
> With,
> 
> Fixes: d9732e498f5f ("drm/xe/xe_ras: Query errors from system controller on probe")

I just realized this actually introduces another problem. I have a bit more
robust fix[1]. Feel free to review.

[1] https://lore.kernel.org/intel-xe/[email protected]

Raag

> Also, IIUC process_hw_errors() suffers from the same problem after commit
> a7df563b45b0 ("drm/xe/xe_hw_error: Handle CSC Firmware reported Hardware
> errors"), which we also might want to fix at some point.