RE: [PATCH] drm/xe/pm: do not warn about missing runtime PM protection after hot-unplug
"Gote, Nitin R" <[email protected]> Thu, 30 Jul 2026 12:05:26 +0000
| Newsgroups | org.freedesktop.lists.intel-xe |
|---|---|
| Message-ID | <SA3PR11MB81184728764B0494D31F1036D0C92@SA3PR11MB8118.namprd11.prod.outlook.com> |
Hi Raag, > -----Original Message----- > From: Jadav, Raag <[email protected]> > Sent: Thursday, July 30, 2026 11:29 AM > To: Gote, Nitin R <[email protected]> > Cc: [email protected]; Brost, Matthew <[email protected]>; > Auld, Matthew <[email protected]> > Subject: Re: [PATCH] drm/xe/pm: do not warn about missing runtime PM > protection after hot-unplug > > On Thu, Jul 30, 2026 at 11:06:36AM +0530, Nitin Gote wrote: > > After hot-unplug, device_del() disables runtime PM. A deferred fd > > close can still run later during process exit and destroy remaining > > exec queues, which may call xe_pm_runtime_get_noresume(). > > This sounds like could cause many other side effects. Why not make sure the exec > queues are taken care of as part of hot-unplug path? > Here In igt@core_hotunplug@hotreplug-with-load and igt@core_hotunplug@hotunplug-rescan-with-load subtests, the workload keeps the DRM fd open while the device is pci hot-unplugged. Later, fd close reaches guc_exec_queue_destroy() -> guc_exec_queue_add_msg() -> xe_pm_runtime_get_noresume(), after pci_remove/device_del() path has already called pm_runtime_disable() during pci hot-unplug. So the WARN is a false-positive for the already-unplugged device case. I will update the commit message to make this scope clearer. Thank you, Nitin > Raag