Re: [PATCH] scripts/kernel-doc: Fix kdoc for Python 3.9-3.11
Akira Yokosawa <[email protected]> Sat, 1 Aug 2026 21:12:00 +0900
| Newsgroups | org.freedesktop.lists.intel-xe,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi, On Fri, 31 Jul 2026 16:45:08 +0200, Ryszard Knop wrote: > The syntax used by the excess description suggestion change works on > Python 3.12+, while we need to support 3.9+. > > Signed-off-by: Ryszard Knop <[email protected]> Tested-by: Akira Yokosawa <[email protected]> And here are needed tags for helping Jon (supposed to go ahead of Sob): Fixes: d7758384ccb4 ("scripts/kernel-doc: Suggest possible names for excess descriptions") Reported-by: Akira Yokosawa <[email protected]> Closes: https://lore.kernel.org/[email protected]/ > --- > tools/lib/python/kdoc/kdoc_parser.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/lib/python/kdoc/kdoc_parser.py b/tools/lib/python/kdoc/kdoc_parser.py > index 884f42584667..9cba20f827c4 100644 > --- a/tools/lib/python/kdoc/kdoc_parser.py > +++ b/tools/lib/python/kdoc/kdoc_parser.py > @@ -601,7 +601,8 @@ class KernelDoc: > if not suggestions: > return "" > > - return f"(did you mean one of: '{"', '".join(suggestions)}')" > + joined_suggestions = "', '".join(suggestions) > + return f"(did you mean one of: '{joined_suggestions}')" > > def check_sections(self, ln, decl_name, decl_type): > """ Thanks, Akira