Re: [PATCH v3 07/23] drm/xe/log: Add SIGID log helpers for location & severity

On 30-07-2026 08:51 pm, Michal Wajdeczko wrote:
> There are only few CPER severity levels defined, add more helpers
> to avoid forcing developers to write full CPER severity name in
> every function call.
>
> Signed-off-by: Michal Wajdeczko <[email protected]>
LGTM,
Reviewed-by: Mallesh Koujalagi <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> ---
> v2: fix argument list (Sashiko)
> ---
>   drivers/gpu/drm/xe/xe_log.h | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_log.h b/drivers/gpu/drm/xe/xe_log.h
> index 510cedae6e14..916218560297 100644
> --- a/drivers/gpu/drm/xe/xe_log.h
> +++ b/drivers/gpu/drm/xe/xe_log.h
> @@ -69,4 +69,20 @@ void xe_log_emit(struct pci_dev *pdev, int cper_sev, enum xe_sigid sigid,
>   		    xe_log_location(___any), (data), (len), fmt, ##args);		\
>   } while (0)
>   
> +#define xe_log_from_fatal(any, sig, comp, data, len, fmt, args...) \
> +	xe_log_from((any), CPER_SEV_FATAL, (sig), (comp), \
> +		    (data), (len), fmt, ##args)
> +
> +#define xe_log_from_recoverable(any, sig, comp, data, len, fmt, args...) \
> +	xe_log_from((any), CPER_SEV_RECOVERABLE, (sig), (comp), \
> +		    (data), (len), fmt, ##args)
> +
> +#define xe_log_from_corrected(any, sig, comp, data, len, fmt, args...) \
> +	xe_log_from((any), CPER_SEV_CORRECTED, (sig), (comp), \
> +		    (data), (len), fmt, ##args)
> +
> +#define xe_log_from_info(any, sig, comp, data, len, fmt, args...) \
> +	xe_log_from((any), CPER_SEV_INFORMATIONAL, (sig), (comp), \
> +		    (data), (len), fmt, ##args)
> +
>   #endif