Re: [PATCH v2 1/4] drm/i915/display: fix SKL_DSSM register macros
Jani Nikula <[email protected]> Tue, 04 Aug 2026 11:01:58 +0300
| Newsgroups | org.freedesktop.lists.intel-xe,org.freedesktop.lists.intel-gfx |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland |
| Message-ID | <[email protected]> |
On Mon, 03 Aug 2026, Micha=C5=82 Grzelak <[email protected]> wrote: > Indent SKL_DSSM register macros. Define mask and register values with > REG_GENMASK() and REG_FIELD_PREP() instead of bit shifts. Nitpick, in subject, "fix" is misleading. This is just cleanup without functional changes. No need to resend for this. Reviewed-by: Jani Nikula <[email protected]> > > v1->v2 > - s/REG_GENMASK/REG_FIELD_PREP/ (Jani) > > Signed-off-by: Micha=C5=82 Grzelak <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_display_regs.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_regs.h b/drivers/= gpu/drm/i915/display/intel_display_regs.h > index 0f5018482497..740331ead20a 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_regs.h > +++ b/drivers/gpu/drm/i915/display/intel_display_regs.h > @@ -1779,10 +1779,10 @@ > #define XE2LPD_DE_CAP_SCALER_SINGLE 1 >=20=20 > #define SKL_DSSM _MMIO(0x51004) > -#define ICL_DSSM_CDCLK_PLL_REFCLK_MASK (7 << 29) > -#define ICL_DSSM_CDCLK_PLL_REFCLK_24MHz (0 << 29) > -#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz (1 << 29) > -#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz (2 << 29) > +#define ICL_DSSM_CDCLK_PLL_REFCLK_MASK REG_GENMASK(31, 29) > +#define ICL_DSSM_CDCLK_PLL_REFCLK_24MHz REG_FIELD_PREP(ICL_DSSM_CDCLK_= PLL_REFCLK_MASK, 0) > +#define ICL_DSSM_CDCLK_PLL_REFCLK_19_2MHz REG_FIELD_PREP(ICL_DSSM_CDCL= K_PLL_REFCLK_MASK, 1) > +#define ICL_DSSM_CDCLK_PLL_REFCLK_38_4MHz REG_FIELD_PREP(ICL_DSSM_CDCL= K_PLL_REFCLK_MASK, 2) >=20=20 > /*GEN11 chicken */ > #define _PIPEA_CHICKEN 0x70038 --=20 Jani Nikula, Intel