Re: [PATCH 01/14] drm/i915/hdmi: Use correct type for output_format parameter

On 8/3/2026 10:02 AM, Kandpal, Suraj wrote:
>> Subject: [PATCH 01/14] drm/i915/hdmi: Use correct type for output_format
>> parameter
>>
>> Correct the data-type of the argument output_format to enum, for the function
>> intel_hdmi_dsc_get_bpp().
>>
> This should have a fixes tag

Hi Suraj,

Thanks for the review, and the comments.

I was also considering the fixes tag initially, but then this looks more 
of a cleanup than fixes.

Since the change only updates the argument type from int to enum, there 
is no functional change. The generated  ABI also remains same.

So IMHO, this doesn't need to be backported to stable kernels, so a 
fixes tag doesn't seem to be required.


Regards,

Ankit


Regards,

Ankit

>
> Otherwise LGTM,
> Reviewed-by: Suraj Kandpal <[email protected]>
>
>> Signed-off-by: Ankit Nautiyal <[email protected]>
>> ---
>>   drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++--
>> drivers/gpu/drm/i915/display/intel_hdmi.h | 4 ++--
>>   2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
>> b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> index 8a019d3574df..9af0f3aba0fc 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> @@ -3338,8 +3338,8 @@ intel_hdmi_dsc_get_num_slices(const struct
>> intel_crtc_state *crtc_state,
>>    */
>>   int
>>   intel_hdmi_dsc_get_bpp(int src_fractional_bpp, int slice_width, int num_slices,
>> -		       int output_format, bool hdmi_all_bpp,
>> -		       int hdmi_max_chunk_bytes)
>> +		       enum intel_output_format output_format,
>> +		       bool hdmi_all_bpp, int hdmi_max_chunk_bytes)
>>   {
>>   	int max_dsc_bpp, min_dsc_bpp;
>>   	int target_bytes;
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.h
>> b/drivers/gpu/drm/i915/display/intel_hdmi.h
>> index 0fa3661568e8..fb950fdd0e7a 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdmi.h
>> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.h
>> @@ -54,8 +54,8 @@ bool intel_hdmi_bpc_possible(const struct
>> intel_crtc_state *crtc_state,
>>   			     int bpc, bool has_hdmi_sink);
>>   int intel_hdmi_tmds_clock(int clock, int bpc, enum intel_output_format
>> sink_format);  int intel_hdmi_dsc_get_bpp(int src_fractional_bpp, int
>> slice_width,
>> -			   int num_slices, int output_format, bool
>> hdmi_all_bpp,
>> -			   int hdmi_max_chunk_bytes);
>> +			   int num_slices, enum intel_output_format
>> output_format,
>> +			   bool hdmi_all_bpp, int hdmi_max_chunk_bytes);
>>   int intel_hdmi_dsc_get_num_slices(const struct intel_crtc_state *crtc_state,
>>   				  int src_max_slices, int src_max_slice_width,
>>   				  int hdmi_max_slices, int hdmi_throughput);
>> --
>> 2.50.1