RE: [PATCH 3/3] drm/xe/display: drop redundant intel_audio_deinit() call

"Shankar, Uma" <[email protected]> Tue, 4 Aug 2026 15:18:12 +0000
Newsgroups org.freedesktop.lists.intel-xe
Message-ID <DM4PR11MB63609009419A75CB84B5A09EF4D42@DM4PR11MB6360.namprd11.prod.outlook.com>

> -----Original Message-----
> From: Intel-xe <[email protected]> On Behalf Of Jani Nikula
> Sent: Tuesday, July 28, 2026 8:20 PM
> To: [email protected]
> Cc: Nikula, Jani <[email protected]>
> Subject: [PATCH 3/3] drm/xe/display: drop redundant intel_audio_deinit() call
> 
> intel_audio_deinit() is already being called via xe_display_unregister()
> -> intel_display_driver_unregister(). Remove the redundant call.

Looks Good to me.
Reviewed-by: Uma Shankar <[email protected]>

> Signed-off-by: Jani Nikula <[email protected]>
> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c
> b/drivers/gpu/drm/xe/display/xe_display.c
> index 2fc12592627c..6800a831c76c 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -18,7 +18,6 @@
>  #include <uapi/drm/xe_drm.h>
> 
>  #include "intel_acpi.h"
> -#include "intel_audio.h"
>  #include "intel_display.h"
>  #include "intel_display_core.h"
>  #include "intel_display_device.h"
> @@ -128,7 +127,6 @@ static void xe_display_fini(void *arg)
>  	struct xe_device *xe = arg;
>  	struct intel_display *display = xe->display;
> 
> -	intel_audio_deinit(display);
>  	intel_display_driver_remove(display);
>  }
> 
> --
> 2.47.3