Re: [RFC PATCH 0/7] Add CPER logging support for CRI

On Thu, Jul 02, 2026 at 04:44:02PM +0530, Badal Nilawar wrote:
> This patch series adds CPER (Common Platform Error Record) logging support
> for Correctable errors reported by Intel Xe GPUs. CPER logging is done
> through trace event.

I had a rough glance and I think this needs to be structured a bit.

1. Introduce a bare minimum emit_cper() which hooks to both correctable and
   uncorrectable error cases.
2. Refactor get_counter() to have a response as its argument and hook it up
   to emit_cper().
3. Introduce Intel CPER structs and all that jazz.
4. Introduce info queue (which is optional, right?) and hook it up to
   emit_cper().
5. Finally introduce trace event for the end user.

Split the patches cleanly if the diff starts to get out of hand and
don't add functions, structs or defines that are not used in that
specific patch.

Raag