RE: [PATCH] drm/i915/dp_mst: Remove duplicate intel_pfit_compute_config() call

> -----Original Message-----
> From: Borah, Chaitanya Kumar <[email protected]>
> Sent: Thursday, August 6, 2026 1:18 PM
> To: [email protected]; [email protected]
> Cc: Borah, Chaitanya Kumar <[email protected]>; Vivi,
> Rodrigo <[email protected]>; Ville Syrjälä <[email protected]>;
> Garg, Nemesa <[email protected]>; Jani Nikula
> <[email protected]>
> Subject: [PATCH] drm/i915/dp_mst: Remove duplicate
> intel_pfit_compute_config() call
> 
> mst_stream_compute_config() called intel_pfit_compute_config() twice in a
> row. Probably because of a bad merge. Drop the redundant duplicate call.
> 
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Ville Syrjälä <[email protected]>
> Cc: Nemesa Garg <[email protected]>
> Cc: Jani Nikula <[email protected]>
> Fixes: 5ce9ac1531b8 ("drm/i915/mst: Call intel_pfit_compute_config() for
> sharpness filter")
> Signed-off-by: Chaitanya Kumar Borah <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 3be1643f8d03..57daed0b0b36 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -761,10 +761,6 @@ static int mst_stream_compute_config(struct
> intel_atomic_state *state,
>  	pipe_config->sink_format = INTEL_OUTPUT_FORMAT_RGB;
>  	pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
> 
> -	ret = intel_pfit_compute_config(pipe_config, conn_state);
> -	if (ret)
> -		return ret;
> -
>  	ret = intel_pfit_compute_config(pipe_config, conn_state);
>  	if (ret)
>  		return ret;
> --
LGTM,
Reviewed-by: Nemesa Garg <[email protected]>

> 2.50.1