Re: [PATCH v3 20/23] drm/xe/pcode: Report 'Mailbox failed' error using SIGID

On 30-07-2026 08:51 pm, Michal Wajdeczko wrote:
> Report 'Mailbox failed' error using xe_log() helper.

Please change to xe_log_err()

with that

Reviewed-by: Mallesh Koujalagi <[email protected]>

>
> Signed-off-by: Michal Wajdeczko <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Riana Tauro <[email protected]>
> Cc: Aravind Iddamsetty <[email protected]>
> Cc: Mallesh Koujalagi <[email protected]>
> ---
>   drivers/gpu/drm/xe/xe_pcode.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
> index ccc3bdeed6bb..014632e11338 100644
> --- a/drivers/gpu/drm/xe/xe_pcode.c
> +++ b/drivers/gpu/drm/xe/xe_pcode.c
> @@ -14,6 +14,7 @@
>   #include "regs/xe_pmt.h"
>   #include "xe_assert.h"
>   #include "xe_device.h"
> +#include "xe_log.h"
>   #include "xe_mmio.h"
>   #include "xe_pcode_api.h"
>   #include "xe_pm.h"
> @@ -61,9 +62,7 @@ static int pcode_mailbox_status(struct xe_tile *tile)
>   	}
>   
>   	if (err) {
> -		drm_err(&tile_to_xe(tile)->drm, "PCODE Mailbox failed: %d %s",
> -			err_decode, err_str);
> -
> +		xe_log_err(tile, PCODE, err_decode, "Mailbox failed: %s\n", err_str);
>   		return err_decode;
>   	}
>