✗ CI.checkpatch: warning for drm/xe/i2c: alerts and controller enabling modifications (rev7)

Patchwork <[email protected]>
Newsgroups org.freedesktop.lists.intel-xe
Message-ID <178645067854.37993.9266318995291072586@61270ab9df2a>
== Series Details ==

Series: drm/xe/i2c: alerts and controller enabling modifications (rev7)
URL   : https://patchwork.freedesktop.org/series/168930/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
061140b9bc586ae7f40abc1249c97e1cc72d1b9d
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f484168ca9be2ab9cde3be22ecaf00e7bcefb08b
Author: Heikki Krogerus <[email protected]>
Date:   Tue Aug 11 14:10:08 2026 +0200

    drm/xe/i2c: Keep the i2c controller always enabled
    
    Some platforms make an assumption that the i2c controller's
    enabled state indicates also the power state of the
    controller. This can create a problem when the controller is
    in disabled state, because the hardware may assume
    incorrectly that it is then also in low-power state.
    
    To fix this, the controller is kept enabled by taking over
    the IC_ENABLE register. The controller has to be disabled
    when the configuration is updated and when the target
    address or the slave address are assigned, so disabling it
    when IC_CON, IC_TAR or IC_SAR registers are programmed, and
    then re-enabling it again.
    
    Fixes: f0e53aadd702 ("drm/xe: Support for I2C attached MCUs")
    Cc: [email protected]
    Signed-off-by: Heikki Krogerus <[email protected]>
+ /mt/dim checkpatch dc462ab791b686c48545c160ecc81be64f77a846 drm-intel
fcee54ac36b2 i2c: designware: Global register definitions
-:191: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#191: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 250 lines checked
cf789b238777 drm/xe/i2c: Fix the interrupt handling
-:51: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

-:235: WARNING:ALLOC_WITH_SIZEOF: Prefer kzalloc_obj over kzalloc with sizeof
#235: FILE: drivers/gpu/drm/xe/xe_amc.c:180:
+	amc = kzalloc(sizeof(*amc), GFP_KERNEL);

total: 0 errors, 2 warnings, 0 checks, 485 lines checked
f484168ca9be drm/xe/i2c: Keep the i2c controller always enabled
-:52: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see function description of usleep_range() and udelay().
#52: FILE: drivers/gpu/drm/xe/xe_i2c.c:232:
+		udelay(25);

total: 0 errors, 0 warnings, 1 checks, 78 lines checked
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.