[PATCH 3/4] drm/xe/pcode: Report pcode errors using SIGID
Umesh Nerlige Ramappa <[email protected]>
| Newsgroups | org.freedesktop.lists.intel-xe |
|---|---|
| Message-ID | <[email protected]> |
Use xe_log_err() to report pcode errors using SIGID. Signed-off-by: Umesh Nerlige Ramappa <[email protected]> --- drivers/gpu/drm/xe/xe_pcode.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c index e9125341481b..b35c1a77effd 100644 --- a/drivers/gpu/drm/xe/xe_pcode.c +++ b/drivers/gpu/drm/xe/xe_pcode.c @@ -14,6 +14,7 @@ #include "regs/xe_pmt.h" #include "xe_assert.h" #include "xe_device.h" +#include "xe_log.h" #include "xe_mmio.h" #include "xe_pcode_api.h" #include "xe_pm.h" @@ -61,9 +62,7 @@ static int pcode_mailbox_status(struct xe_tile *tile) } if (err) { - drm_err(&tile_to_xe(tile)->drm, "PCODE Mailbox failed: %d %s", - err_decode, err_str); - + xe_log_err(tile, PCODE, err_decode, "Mailbox failed: %s\n", err_str); return err_decode; } @@ -225,6 +224,9 @@ int xe_pcode_request(struct xe_tile *tile, u32 mbox, u32 request, true, 50 * 1000, true); preempt_enable(); + if (!status && ret) + xe_log_err(tile, PCODE, ret, "Request timed out on retry"); + out: mutex_unlock(&tile->pcode.lock); return status ? status : ret; @@ -319,8 +321,8 @@ int xe_pcode_ready(struct xe_device *xe, bool locked) mutex_unlock(&tile->pcode.lock); if (ret) - drm_err(&xe->drm, - "PCODE initialization timedout after: 3 min\n"); + xe_log_err(xe, PCODE, -ret, + "Initialization timed out after: %d min\n", timeout_us / 60000000); return ret; } -- 2.51.0