Re: [PATCH v3 21/23] drm/xe/gt: Report 'reset failed' errors using SIGID

On 30-07-2026 08:51 pm, Michal Wajdeczko wrote:
> Report 'reset' related err/info messages using xe_log() helpers.
>
> Signed-off-by: Michal Wajdeczko <[email protected]>
LGTM,
Reviewed-by: Mallesh Koujalagi <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Matthew Brost <[email protected]>
> Cc: Daniele Ceraolo Spurio <[email protected]>
> Cc: Aravind Iddamsetty <[email protected]>
> Cc: Mallesh Koujalagi <[email protected]>
> ---
>   drivers/gpu/drm/xe/xe_gt.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index dfdacc0f6de9..6805e0d3bf21 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -48,6 +48,7 @@
>   #include "xe_hw_engine_class_sysfs.h"
>   #include "xe_irq.h"
>   #include "xe_lmtt.h"
> +#include "xe_log.h"
>   #include "xe_lrc.h"
>   #include "xe_map.h"
>   #include "xe_migrate.h"
> @@ -925,7 +926,7 @@ static void gt_reset_worker(struct work_struct *w)
>   	if (!xe_device_uc_enabled(gt_to_xe(gt)))
>   		goto err_pm_put;
>   
> -	xe_gt_info(gt, "reset started\n");
> +	xe_log_info(gt, GT, "reset started\n");
>   
>   	if (xe_fault_gt_reset()) {
>   		err = -ECANCELED;
> @@ -964,7 +965,7 @@ static void gt_reset_worker(struct work_struct *w)
>   	/* Pair with get while enqueueing the work in xe_gt_reset_async() */
>   	xe_pm_runtime_put(gt_to_xe(gt));
>   
> -	xe_gt_info(gt, "reset done\n");
> +	xe_log_info(gt, GT, "reset done\n");
>   
>   	return;
>   
> @@ -973,7 +974,7 @@ static void gt_reset_worker(struct work_struct *w)
>   	XE_WARN_ON(xe_uc_start(&gt->uc));
>   
>   err_fail:
> -	xe_gt_err(gt, "reset failed (%pe)\n", ERR_PTR(err));
> +	xe_log_err_fatal(gt, GT, err, "reset failed\n");
>   	xe_device_declare_wedged(gt_to_xe(gt));
>   err_pm_put:
>   	xe_pm_runtime_put(gt_to_xe(gt));