Re: [PATCH v3 11/23] drm/xe/log: Extend components list with hardware items

On 04-08-2026 11:35, Mallesh, Koujalagi wrote:
>
> On 30-07-2026 08:51 pm, Michal Wajdeczko wrote:
>> Update our super macro with new top level hardware components.
>>
>> Signed-off-by: Michal Wajdeczko <[email protected]>
> LGTM,
> Reviewed-by: Mallesh Koujalagi <[email protected]>
>> Cc: Rodrigo Vivi <[email protected]>
>> Cc: Aravind Iddamsetty <[email protected]>
>> ---
>> v2: follow enum xe_ras_component values (Aravind)
>> ---
>>   drivers/gpu/drm/xe/abi/xe_log_abi.h | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/abi/xe_log_abi.h 
>> b/drivers/gpu/drm/xe/abi/xe_log_abi.h
>> index 4861a5b58c10..b3373d4b29d5 100644
>> --- a/drivers/gpu/drm/xe/abi/xe_log_abi.h
>> +++ b/drivers/gpu/drm/xe/abi/xe_log_abi.h
>> @@ -129,6 +129,10 @@ enum xe_log_location_bits {
>>    *     @SIGID is the default xe_sigid for the component (without 
>> the XE_SIGID_ prefix)
>>    */
>>   #define DEFINE_XE_LOG_COMPONENTS(define) \
>> +    DEFINE_XE_LOG_SOFTWARE_COMPONENTS(define) \
>> +    DEFINE_XE_LOG_HARDWARE_COMPONENTS(define)
>> +
>> +#define DEFINE_XE_LOG_SOFTWARE_COMPONENTS(define) \
>>       /* */                                    \
>>       define(SYSTEM, 1, PCI, SW, "Linux PCI Subsystem")            \
>>       define(SYSTEM, 2, DRM, SW, "DRM")                    \
>> @@ -156,6 +160,14 @@ enum xe_log_location_bits {
>>       define(DRIVER_FIRMWARE, 3, GSC, RUNTIME_FW, "GSC")            \
>>       define(DRIVER_FIRMWARE, 16, PCODE, DEVICE_FW, 
>> "PCode")            \
>>       define(DRIVER_FIRMWARE, 17, SYSCTRL, DEVICE_FW, "System 
>> Controller")    \
>> +
>> +#define DEFINE_XE_LOG_HARDWARE_COMPONENTS(define) \
>> +    define(HARDWARE, 1, DEVMEM, DEVICE_MEMORY, "Device 
>> Memory")        \

DEVICE_MEMORY

>> +    define(HARDWARE, 2, HWCORE, CORE_COMPUTE, "Core Compute")        \

Core_compute

>> +    /*     HARDWARE, 3, RESERVED */                        \
>> +    define(HARDWARE, 4, PCIE, PCIE, "PCIe Interface")            \
>> +    define(HARDWARE, 5, FABRIC, FABRIC, "Fabric")                \
>> +    define(HARDWARE, 6, SOC, SOC_INTERNAL, "SoC Internal")            \
SOC_INTERNAL

Let's retain the names same as UAPI to avoid unnecessary confusion while 
collecting CPER logs.

These names were asked to be retained similar to actual hardware error 
classification even for uapi.

++@Aravind

Thanks
Riana


>>       /* eod */
>>     /**