Re: [PATCH v2 2/3] drm/xe/pcode: Improve PCODE logging using xe_log helper

On 12-08-2026 06:23 pm, Bhadane, Dnyaneshwar wrote:
>
>> -----Original Message-----
>> From: Koujalagi, Mallesh <[email protected]>
>> Sent: Wednesday, August 12, 2026 6:05 PM
>> To: [email protected]; Vivi, Rodrigo <[email protected]>; Brost,
>> Matthew <[email protected]>
>> Cc: Gupta, Anshuman <[email protected]>; Nilawar, Badal
>> <[email protected]>; Belgaumkar, Vinay <[email protected]>;
>> Tauro, Riana <[email protected]>; Poosa, Karthik
>> <[email protected]>; Anirban, Sk <[email protected]>; Jadav, Raag
>> <[email protected]>; Wajdeczko, Michal <[email protected]>;
>> [email protected]; Nerlige Ramappa, Umesh
>> <[email protected]>; Bhadane, Dnyaneshwar
>> <[email protected]>; Koujalagi, Mallesh
>> <[email protected]>
>> Subject: [PATCH v2 2/3] drm/xe/pcode: Improve PCODE logging using xe_log
>> helper
>>
>> Use xe_log helper for PCODE errors instead of drm_err(). This adds PCODE
>> component tag, making issues easier to detect and track with automated tools.
>>
>> Signed-off-by: Mallesh Koujalagi <[email protected]>
>> ---
>> v2:
>> - s/pcode/PCODE. (Michal)
>> - Drop PCODE in xe_log_err.
>> ---
>>   drivers/gpu/drm/xe/xe_pcode.c | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
>> index ccc3bdeed6bb..c69440ea477b 100644
>> --- a/drivers/gpu/drm/xe/xe_pcode.c
>> +++ b/drivers/gpu/drm/xe/xe_pcode.c
>> @@ -14,6 +14,7 @@
>>   #include "regs/xe_pmt.h"
>>   #include "xe_assert.h"
>>   #include "xe_device.h"
>> +#include "xe_log.h"
>>   #include "xe_mmio.h"
>>   #include "xe_pcode_api.h"
>>   #include "xe_pm.h"
>> @@ -219,8 +220,8 @@ int xe_pcode_request(struct xe_tile *tile, u32 mbox, u32
>> request,
>>   	 * requests, and for any quirks of the PCODE firmware that delays
>>   	 * the request completion.
>>   	 */
>> -	drm_err(&tile_to_xe(tile)->drm,
>> -		"PCODE timeout, retrying with preemption disabled\n");
>> +	xe_log_err(tile, PCODE, -ETIMEDOUT,
>> +		   "Timeout, retrying with preemption disabled\n");
>>   	preempt_disable();
>>   	ret = pcode_try_request(tile, mbox, request, reply_mask, reply, &status,
>>   				true, 50 * 1000, true);
>> @@ -320,8 +321,8 @@ int xe_pcode_ready(struct xe_device *xe, bool locked)
>>   		mutex_unlock(&tile->pcode.lock);
>>
>>   	if (ret)
>> -		drm_err(&xe->drm,
>> -			"PCODE initialization timedout after: 3 min\n");
>> +		xe_log_err(xe, PCODE, ret,
>> +			   "Initialization timedout after: 3 min\n");
>>
>>   	return ret;
>>   }
> Hello Mallesh,
> This is one more place inside of the pcode_mailbox_status().
> Could you please include that as well to this patch ?

That already covered in SIGID the patch series: 
https://patchwork.freedesktop.org/patch/743325/?series=171022&rev=3

Thanks,

-/Mallesh


> Dnyaneshwar
>
>> --
>> 2.48.1