Re: [PATCH v4 09/32] drm/xe/log: Add SIGID log helpers for component & severity

On 13-08-2026 12:44 am, Michal Wajdeczko wrote:
> There are only few CPER severity levels defined, add some helpers
> to avoid forcing developers to write full CPER severity enum name
> in every macro call.
>
> Signed-off-by: Michal Wajdeczko <[email protected]>
LGTM,
Reviewed-by: Mallesh Koujalagi <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Mallesh Koujalagi <[email protected]>
> ---
>   drivers/gpu/drm/xe/xe_log.h | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_log.h b/drivers/gpu/drm/xe/xe_log.h
> index c30db02950b0..c56306a183e7 100644
> --- a/drivers/gpu/drm/xe/xe_log.h
> +++ b/drivers/gpu/drm/xe/xe_log.h
> @@ -103,4 +103,16 @@ void xe_log_emit(struct pci_dev *pdev, int cper_sev, enum xe_sigid sigid,
>   	xe_log_from((any), (cper_sev), (int)XE_LOG_COMPONENT_##TAG##_SIGID, \
>   		    XE_LOG_COMPONENT_##TAG, (data), (len), fmt, ##args)
>   
> +#define xe_log_comp_fatal(any, TAG, data, len, fmt, args...) \
> +	xe_log_comp((any), CPER_SEV_FATAL, TAG, (data), (len), fmt, ##args)
> +
> +#define xe_log_comp_recoverable(any, TAG, data, len, fmt, args...) \
> +	xe_log_comp((any), CPER_SEV_RECOVERABLE, TAG, (data), (len), fmt, ##args)
> +
> +#define xe_log_comp_corrected(any, TAG, data, len, fmt, args...) \
> +	xe_log_comp((any), CPER_SEV_CORRECTED, TAG, (data), (len), fmt, ##args)
> +
> +#define xe_log_comp_info(any, TAG, data, len, fmt, args...) \
> +	xe_log_comp((any), CPER_SEV_INFORMATIONAL, TAG, (data), (len), fmt, ##args)
> +
>   #endif