Re: [PATCH v4 18/32] drm/xe: Report 'probe blocked' error using SIGID

On 13-08-2026 12:44 am, Michal Wajdeczko wrote:
> Report 'driver loading blocked' error using xe_log_info() helper.
>
> Signed-off-by: Michal Wajdeczko <[email protected]>

Simply we are logging information using xe_log_info right? not error.

If you want to log as error then please use xe_log_err right?

Please update commit accordingly.

After above changes

Reviewed-by: Mallesh Koujalagi <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Aravind Iddamsetty <[email protected]>
> Cc: Mallesh Koujalagi <[email protected]>
> ---
> v2: use info severity (Aravind)
> v3: drop "Probe " prefix (Mallesh)
>      drop redundant vendor code, update message (Michal)
> ---
>   drivers/gpu/drm/xe/xe_pci.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 36d62927b969..b19efef1c5cd 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -25,6 +25,7 @@
>   #include "xe_gt_printk.h"
>   #include "xe_gt_sriov_vf.h"
>   #include "xe_guc.h"
> +#include "xe_log.h"
>   #include "xe_mmio.h"
>   #include "xe_module.h"
>   #include "xe_pci_error.h"
> @@ -1172,8 +1173,8 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	}
>   
>   	if (id_blocked(pdev->device)) {
> -		dev_info(&pdev->dev, "Probe blocked for device [%04x:%04x].\n",
> -			 pdev->vendor, pdev->device);
> +		xe_log_info(pdev, PROBE, "driver loading blocked for device '%04x'\n",
> +			    pdev->device);
>   		return -ENODEV;
>   	}
>