RE: [PATCH v4 25/32] drm/xe/pcode: Report 'Mailbox failed' error using SIGID

> -----Original Message-----
> From: Intel-xe <[email protected]> On Behalf Of Michal
> Wajdeczko
> Sent: Thursday, August 13, 2026 12:45 AM
> To: [email protected]
> Cc: Wajdeczko, Michal <[email protected]>; Vivi, Rodrigo
> <[email protected]>; Tauro, Riana <[email protected]>; Iddamsetty,
> Aravind <[email protected]>; Koujalagi, Mallesh
> <[email protected]>
> Subject: [PATCH v4 25/32] drm/xe/pcode: Report 'Mailbox failed' error using
> SIGID
> 
> Report 'Mailbox failed' error using xe_log_err() helper.
> 
> Signed-off-by: Michal Wajdeczko <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Riana Tauro <[email protected]>
> Cc: Aravind Iddamsetty <[email protected]>
> Cc: Mallesh Koujalagi <[email protected]>
> Reviewed-by: Mallesh Koujalagi <[email protected]>
> ---
> v2: say xe_log_err() in commit msg (Mallesh)
> ---
>  drivers/gpu/drm/xe/xe_pcode.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
> index ccc3bdeed6bb..014632e11338 100644
> --- a/drivers/gpu/drm/xe/xe_pcode.c
> +++ b/drivers/gpu/drm/xe/xe_pcode.c
> @@ -14,6 +14,7 @@
>  #include "regs/xe_pmt.h"
>  #include "xe_assert.h"
>  #include "xe_device.h"
> +#include "xe_log.h"
>  #include "xe_mmio.h"
>  #include "xe_pcode_api.h"
>  #include "xe_pm.h"
> @@ -61,9 +62,7 @@ static int pcode_mailbox_status(struct xe_tile *tile)
>  	}
> 
>  	if (err) {
> -		drm_err(&tile_to_xe(tile)->drm, "PCODE Mailbox failed: %d %s",
> -			err_decode, err_str);
> -
> +		xe_log_err(tile, PCODE, err_decode, "Mailbox failed: %s\n",
> err_str);
>  		return err_decode;
Hey, 
Could you please merge patch number #25, #26 and #27 into single patch ?
Or is there any thought to kept as separate. ? 

Regards, 
Dnyaneshwar
>  	}
> 
> --
> 2.47.1