Re: [PATCH v4 26/32] drm/xe/pcode: Report 'timeout, retrying' error using SIGID

On Wed, Aug 12, 2026 at 09:14:42PM +0200, Michal Wajdeczko wrote:
>Report 'timeout, retrying with preemption disabled' error using
>xe_log_err() helper.
>
>Signed-off-by: Michal Wajdeczko <[email protected]>
>Cc: Rodrigo Vivi <[email protected]>
>Cc: Riana Tauro <[email protected]>
>Cc: Aravind Iddamsetty <[email protected]>
>Cc: Mallesh Koujalagi <[email protected]>
>---
> drivers/gpu/drm/xe/xe_pcode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
>index 014632e11338..14b13a11d1d6 100644
>--- a/drivers/gpu/drm/xe/xe_pcode.c
>+++ b/drivers/gpu/drm/xe/xe_pcode.c
>@@ -218,8 +218,7 @@ int xe_pcode_request(struct xe_tile *tile, u32 mbox, u32 request,
> 	 * requests, and for any quirks of the PCODE firmware that delays
> 	 * the request completion.
> 	 */
>-	drm_err(&tile_to_xe(tile)->drm,
>-		"PCODE timeout, retrying with preemption disabled\n");
>+	xe_log_err(tile, PCODE, ret, "timeout, retrying with preemption disabled\n");
> 	preempt_disable();
> 	ret = pcode_try_request(tile, mbox, request, reply_mask, reply, &status,
> 				true, 50 * 1000, true);

+ Badal

Should we report the drm_err before retrying?

Should we add a new log to report a failure after retry?

Thanks,
Umesh

>-- 2.47.1
>