Re: [PATCH v4 02/32] drm/xe/log: Add structured SIGID error logging infrastructure

On 8/13/2026 3:42 PM, Nilawar, Badal wrote:
> Hi Michal,

...

> 
> From kunit example I got this output for hardware errors.
> drm-kunit-mock-device demo_dmesg.drm-kunit-mock-device: [drm] *ERROR* SIGID=204 (0102030405060708090a0b0c) [Hardware Error]: testing HARDWARE signature
> drm-kunit-mock-device demo_dmesg.drm-kunit-mock-device: [drm] *ERROR* SIGID=202 CORRECTED (0102030405060708090a0b0c) [Hardware Error]: Tile1: testing HARDWARE signature
> 
> SIGIDs 202 and 204 correspond to the XE_RAS_COMP_DEVICE_MEMORY and XE_RAS_COMP_FABRIC components returned by firmware via xe_ras_error_class.
> If we want the component name to be included in the error message, what should be passed to the logging helper? The current KUnit test uses XE_LOG_COMPONENT_NONE, so no component information is being emitted.

if you want HW component name to be explicitly included like
we do for SW errors, use xe_log_comp_xxx() macros:

-       xe_log_emit_recoverable(pdev, XE_SIGID_FABRIC,
-                               XE_LOG_COMPONENT_NONE, XE_LOG_LOCATION_NONE,
+       xe_log_comp_recoverable(pdev, FABRIC,
                                blob, sizeof(blob), "testing %s signature\n", "HARDWARE");
-       xe_log_from_corrected(tile, XE_SIGID_DEVICE_MEMORY, XE_LOG_COMPONENT_NONE,
+       xe_log_comp_corrected(tile, DEVICE_MEMORY,
                              blob, sizeof(blob), "testing %s signature\n", "HARDWARE");

then you will get:

.. [drm] *ERROR* SIGID=204 (0102030405060708090a0b0c) [Hardware Error]: FABRIC: testing HARDWARE signature
.. [drm] *ERROR* SIGID=202 CORRECTED (0102030405060708090a0b0c) [Hardware Error]: Tile1: DEVICE_MEMORY: testing HARDWARE signature


and btw, I will ask again, whether we want LOCATION/COMPONENT
decoration as here:

	Tile1: GT1: PROBE: testing software signature
	Tile1: DEVICE_MEMORY: testing HARDWARE signature

or maybe in COMPONENT/LOCATION order:

	PROBE: Tile1: GT1: testing software signature
	DEVICE_MEMORY: Tile1: testing HARDWARE signature

if latter, then please comment patch 4/32

> 
> Thanks,
> Badal
>