[PATCH v5 32/33] drm/xe/gt: Report 'Queue full' pagefault error using SIGID
Michal Wajdeczko <[email protected]>
| Newsgroups | org.freedesktop.lists.intel-xe |
|---|---|
| Message-ID | <[email protected]> |
Report 'Queue full' error using xe_log_err() helper. While around, replace WARN_ON with WARN_ON_ONCE as there is no need for extra noise each time we hit this unlikely condition. Signed-off-by: Michal Wajdeczko <[email protected]> Cc: Rodrigo Vivi <[email protected]> Cc: Matthew Brost <[email protected]> Cc: Daniele Ceraolo Spurio <[email protected]> Cc: Aravind Iddamsetty <[email protected]> Cc: Mallesh Koujalagi <[email protected]> Reviewed-by: Rodrigo Vivi <[email protected]> --- v2: mention WARN_ON_ONCE change in commit msg (Rodrigo) --- drivers/gpu/drm/xe/xe_pagefault.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c index 8b1f6f5448ba..9e89d7b37395 100644 --- a/drivers/gpu/drm/xe/xe_pagefault.c +++ b/drivers/gpu/drm/xe/xe_pagefault.c @@ -328,8 +328,10 @@ xe_pagefault_queue_add(struct xe_pagefault_queue *pf_queue, do { /* Not possible, warn on and drop page fault */ - if (WARN_ON(xe_pagefault_queue_full(pf_queue))) + if (WARN_ON_ONCE(xe_pagefault_queue_full(pf_queue))) { + xe_log_err(xe, PAGEFAULT, -ENOSPC, "Queue full!\n"); return NULL; + } lpf = (pf_queue->data + pf_queue->head); pf_queue->head = (pf_queue->head + xe_pagefault_entry_size()) % -- 2.47.1