Re: [PATCH v5 13/33] drm/xe/log: Extend components list with hardware items

On Fri, Aug 14, 2026 at 07:17:39PM +0200, Michal Wajdeczko wrote:
> Update our super macro with new top level hardware components.
> 
> Signed-off-by: Michal Wajdeczko <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Aravind Iddamsetty <[email protected]>
> Reviewed-by: Mallesh Koujalagi <[email protected]> #v2
> Cc: Riana Tauro <[email protected]>
> ---
> v2: follow enum xe_ras_component values (Aravind)
> v3: use same COMP tags as in SIGID (Riana)

indeed better,

Reviewed-by: Rodrigo Vivi <[email protected]>

> ---
>  drivers/gpu/drm/xe/abi/xe_log_abi.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/abi/xe_log_abi.h b/drivers/gpu/drm/xe/abi/xe_log_abi.h
> index b38db5e9fcb5..d6105520173e 100644
> --- a/drivers/gpu/drm/xe/abi/xe_log_abi.h
> +++ b/drivers/gpu/drm/xe/abi/xe_log_abi.h
> @@ -130,6 +130,10 @@ enum xe_log_location_bits {
>   *     @SIGID is the default xe_sigid for the component (without the XE_SIGID_ prefix)
>   */
>  #define DEFINE_XE_LOG_COMPONENTS(define) \
> +	DEFINE_XE_LOG_SOFTWARE_COMPONENTS(define) \
> +	DEFINE_XE_LOG_HARDWARE_COMPONENTS(define)
> +
> +#define DEFINE_XE_LOG_SOFTWARE_COMPONENTS(define) \
>  	/* */									\
>  	define(SYSTEM, 1, PCI, IO_BUS, "Linux PCI Subsystem")			\
>  	define(SYSTEM, 2, DRM, SW, "DRM")					\
> @@ -157,6 +161,14 @@ enum xe_log_location_bits {
>  	define(DRIVER_FIRMWARE, 3, GSC, RUNTIME_FW, "GSC")			\
>  	define(DRIVER_FIRMWARE, 16, PCODE, DEVICE_FW, "PCode")			\
>  	define(DRIVER_FIRMWARE, 17, SYSCTRL, DEVICE_FW, "System Controller")	\
> +
> +#define DEFINE_XE_LOG_HARDWARE_COMPONENTS(define) \
> +	define(HARDWARE, 1, DEVICE_MEMORY, DEVICE_MEMORY, "Device Memory")	\
> +	define(HARDWARE, 2, CORE_COMPUTE, CORE_COMPUTE, "Core Compute")		\
> +	/*     HARDWARE, 3, RESERVED */						\
> +	define(HARDWARE, 4, PCIE, PCIE, "PCIe Interface")			\
> +	define(HARDWARE, 5, FABRIC, FABRIC, "Fabric")				\
> +	define(HARDWARE, 6, SOC_INTERNAL, SOC_INTERNAL, "SoC Internal")		\
>  	/* eod */
>  
>  /**
> -- 
> 2.47.1
>