Re: [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
| Newsgroups | org.freedesktop.lists.intel-xe |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Selecting DRM_RAS in DRM_XE without inheriting its dependency on NET causes Kconfig warnings and potential build failures. -- --- Patch [1]: [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS --- commit 591f0eb274f545521022c1143984b07f3d4b5395 Author: Balasubramani Vivekanandan <[email protected]> drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS This commit enables DRM RAS support for the Xe driver by adding a select statement for DRM_RAS in the DRM_XE Kconfig entry. > diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig > index 4d7dcaff2b915..6c584f918edf2 100644 > --- a/drivers/gpu/drm/xe/Kconfig > +++ b/drivers/gpu/drm/xe/Kconfig > @@ -42,6 +42,7 @@ config DRM_XE > select DRM_GPUSVM if !UML > select DRM_GPUVM > select DRM_SCHED > + select DRM_RAS [Severity: Low] Does this select statement need to inherit the dependencies of DRM_RAS? DRM_RAS depends on NET. Since DRM_XE selects DRM_RAS without inheriting this dependency, it can cause Kconfig unmet direct dependency warnings and potential build failures if the kernel is configured with CONFIG_NET disabled. > select MMU_NOTIFIER > select WANT_DEV_COREDUMP > select AUXILIARY_BUS -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1