Re: [PATCH v1] drm/xe/pci_error: Allow debugging PCI errors
"Tauro, Riana" <[email protected]>
| Newsgroups | org.freedesktop.lists.intel-xe |
|---|---|
| Message-ID | <[email protected]> |
On 14-08-2026 20:01, Raag Jadav wrote: > XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET is intended for debugging hangs. > Disconnect the device on AER and prevent bus reset, so that it is available > to the user for debugging. > > Signed-off-by: Raag Jadav <[email protected]> > --- > drivers/gpu/drm/xe/xe_pci_error.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_pci_error.c b/drivers/gpu/drm/xe/xe_pci_error.c > index e41af2ac7f23..4858ce2f9c19 100644 > --- a/drivers/gpu/drm/xe/xe_pci_error.c > +++ b/drivers/gpu/drm/xe/xe_pci_error.c > @@ -63,6 +63,12 @@ static pci_ers_result_t xe_pci_error_detected(struct pci_dev *pdev, pci_channel_ > if (xe_survivability_mode_is_boot_enabled(xe) || xe_device_wedged(xe)) > return PCI_ERS_RESULT_DISCONNECT; > > + /* User wants to debug the error, prevent reset */ > + if (xe->wedged.mode == XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET) { > + xe_device_declare_wedged(xe); > + return PCI_ERS_RESULT_DISCONNECT; > + } This should be for nonfatal errors in mmio_enabled after processing the errors. Also for fatal errors, we cannot skip recovery as pci port driver requests reset. Either way it should be moved to mmio enabled. Thanks Riana > + > switch (state) { > case pci_channel_io_normal: > return PCI_ERS_RESULT_CAN_RECOVER;