[PATCH v4 6/7] drm/xe/sysctrl: Log group and command ID on mailbox failure
Mallesh Koujalagi <[email protected]>
| Newsgroups | org.freedesktop.lists.intel-xe |
|---|---|
| Message-ID | <[email protected]> |
Include the mailbox group ID and command code in error logs for command preparation and execution failures. Signed-off-by: Mallesh Koujalagi <[email protected]> --- drivers/gpu/drm/xe/xe_sysctrl_mailbox.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c index 9d7915c9d4ae..dd4cf8ad1279 100644 --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c @@ -373,7 +373,8 @@ int xe_sysctrl_send_command(struct xe_sysctrl *sc, cmd->data_in, cmd->data_in_len, &mbox_cmd, &cmd_size); if (ret) { - xe_err(xe, "sysctrl: Failed to prepare command: %pe\n", ERR_PTR(ret)); + xe_log_err(xe, SYSCTRL, ret, "Failed to prepare command group=0x%02x cmd=0x%02x\n", + group_id, command_code); return ret; } @@ -383,7 +384,8 @@ int xe_sysctrl_send_command(struct xe_sysctrl *sc, cmd->data_out, cmd->data_out_len, rdata_len, XE_SYSCTRL_MB_DEFAULT_TIMEOUT_MS); if (ret) - xe_err(xe, "sysctrl: Mailbox command failed: %pe\n", ERR_PTR(ret)); + xe_log_err(xe, SYSCTRL, ret, "Mailbox command failed group=0x%02x cmd=0x%02x\n", + group_id, command_code); kfree(mbox_cmd); -- 2.48.1