[PATCH v10 05/10] drm/xe/exec_queue: Introduce xe_exec_queue_reinit()
Raag Jadav <[email protected]>
| Newsgroups | org.freedesktop.lists.intel-xe |
|---|---|
| Message-ID | <[email protected]> |
In preparation of usecases which require re-initializing exec queue after PCIe FLR, introduce xe_exec_queue_reinit() helper. All the exec queue LCRs already exist but the context is lost on PCIe FLR and needs re-initialization. Signed-off-by: Raag Jadav <[email protected]> Tested-by: Lukasz Laguna <[email protected]> Reviewed-by: Daniele Ceraolo Spurio <[email protected]> --- v2: Re-initialize migrate context (Matthew Brost) v6: Add IS_DGFX() and EXEC_QUEUE_FLAG_KERNEL asserts (Daniele) v9: Add negative asserts for GSC and PXP (Daniele) Provide xe_lrc_ctx_init() as regular function (Daniele) --- drivers/gpu/drm/xe/xe_exec_queue.c | 47 +++++++++++++++++++++++++++--- drivers/gpu/drm/xe/xe_exec_queue.h | 1 + drivers/gpu/drm/xe/xe_lrc.c | 15 ++++++++-- drivers/gpu/drm/xe/xe_lrc.h | 2 ++ 4 files changed, 59 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c index c4213bb9c137..ffff9efe518f 100644 --- a/drivers/gpu/drm/xe/xe_exec_queue.c +++ b/drivers/gpu/drm/xe/xe_exec_queue.c @@ -27,6 +27,7 @@ #include "xe_migrate.h" #include "xe_pm.h" #include "xe_trace.h" +#include "xe_uc_fw.h" #include "xe_vm.h" #include "xe_pxp.h" @@ -332,9 +333,8 @@ static void __xe_exec_queue_fini(struct xe_exec_queue *q) xe_lrc_put(q->lrc[i]); } -static int __xe_exec_queue_init(struct xe_exec_queue *q, u32 exec_queue_flags) +static u32 xe_lrc_init_flags(struct xe_exec_queue *q, u32 exec_queue_flags) { - int i, err; u32 flags = 0; /* @@ -357,6 +357,13 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q, u32 exec_queue_flags) if (q->flags & EXEC_QUEUE_FLAG_DISABLE_STATE_CACHE_PERF_FIX) flags |= XE_LRC_DISABLE_STATE_CACHE_PERF_FIX; + return flags; +} + +static int __xe_exec_queue_init(struct xe_exec_queue *q, u32 exec_queue_flags) +{ + int i, err; + err = q->ops->init(q); if (err) return err; @@ -380,8 +387,8 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q, u32 exec_queue_flags) marker = xe_gt_sriov_vf_wait_valid_ggtt(q->gt); - lrc = xe_lrc_create(q->hwe, q->vm, q->replay_state, - xe_lrc_ring_size(), q->msix_vec, flags); + lrc = xe_lrc_create(q->hwe, q->vm, q->replay_state, xe_lrc_ring_size(), + q->msix_vec, xe_lrc_init_flags(q, exec_queue_flags)); if (IS_ERR(lrc)) { err = PTR_ERR(lrc); goto err_lrc; @@ -403,6 +410,38 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q, u32 exec_queue_flags) return err; } +/** + * xe_exec_queue_reinit() - Re-initialize exec queue + * @q: exec queue to re-initialize + * + * Returns: 0 on success, negative error code otherwise. + */ +int xe_exec_queue_reinit(struct xe_exec_queue *q) +{ + struct xe_gt *gt = q->gt; + int i, err; + + /* TODO: Re-initialize GSC and PXP queues */ + xe_gt_assert(gt, IS_DGFX(gt_to_xe(gt))); + xe_gt_assert(gt, !xe_uc_fw_is_loadable(>->uc.gsc.fw)); + xe_gt_assert(gt, !xe_pxp_is_enabled(gt_to_xe(gt)->pxp)); + + /* Re-initialization only allowed for kernel queues */ + xe_gt_assert(gt, q->flags & EXEC_QUEUE_FLAG_KERNEL); + + /* Re-initialize submission backend */ + q->ops->reinit_kernel(q); + + for (i = 0; i < q->width; i++) { + err = xe_lrc_ctx_init(q->lrc[i], q->hwe, q->vm, q->replay_state, + q->msix_vec, xe_lrc_init_flags(q, q->flags)); + if (err) + return err; + } + + return 0; +} + /** * xe_exec_queue_create() - Create an exec queue * @xe: Xe device diff --git a/drivers/gpu/drm/xe/xe_exec_queue.h b/drivers/gpu/drm/xe/xe_exec_queue.h index 0225426c57b0..236fa44c2a72 100644 --- a/drivers/gpu/drm/xe/xe_exec_queue.h +++ b/drivers/gpu/drm/xe/xe_exec_queue.h @@ -34,6 +34,7 @@ struct xe_exec_queue *xe_exec_queue_create_bind(struct xe_device *xe, void xe_exec_queue_fini(struct xe_exec_queue *q); void xe_exec_queue_destroy(struct kref *ref); void xe_exec_queue_assign_name(struct xe_exec_queue *q, u32 instance); +int xe_exec_queue_reinit(struct xe_exec_queue *q); static inline struct xe_exec_queue * xe_exec_queue_get_unless_zero(struct xe_exec_queue *q) diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c index 35b4e8289b5f..79b363978ea4 100644 --- a/drivers/gpu/drm/xe/xe_lrc.c +++ b/drivers/gpu/drm/xe/xe_lrc.c @@ -1486,8 +1486,19 @@ void xe_lrc_set_multi_queue_priority(struct xe_lrc *lrc, enum xe_multi_queue_pri lrc->desc |= FIELD_PREP(LRC_PRIORITY, xe_multi_queue_prio_to_lrc(lrc, priority)); } -static int xe_lrc_ctx_init(struct xe_lrc *lrc, struct xe_hw_engine *hwe, struct xe_vm *vm, - void *replay_state, u16 msix_vec, u32 init_flags) +/** + * xe_lrc_ctx_init() - Initialize LRC with context details + * @lrc: Pointer to the LRC + * @hwe: Hardware Engine + * @vm: The VM (address space) + * @replay_state: GPU hang replay state + * @msix_vec: MSI-X interrupt vector (for platforms that support it) + * @init_flags: LRC initialization flags + * + * Returns: 0 on success, negative error code otherwise. + */ +int xe_lrc_ctx_init(struct xe_lrc *lrc, struct xe_hw_engine *hwe, struct xe_vm *vm, + void *replay_state, u16 msix_vec, u32 init_flags) { struct xe_gt *gt = hwe->gt; struct xe_tile *tile = gt_to_tile(gt); diff --git a/drivers/gpu/drm/xe/xe_lrc.h b/drivers/gpu/drm/xe/xe_lrc.h index 7be5e3da8bc8..0af66013fa29 100644 --- a/drivers/gpu/drm/xe/xe_lrc.h +++ b/drivers/gpu/drm/xe/xe_lrc.h @@ -63,6 +63,8 @@ struct xe_lrc_snapshot { struct xe_lrc *xe_lrc_create(struct xe_hw_engine *hwe, struct xe_vm *vm, void *replay_state, u32 ring_size, u16 msix_vec, u32 flags); +int xe_lrc_ctx_init(struct xe_lrc *lrc, struct xe_hw_engine *hwe, struct xe_vm *vm, + void *replay_state, u16 msix_vec, u32 init_flags); void xe_lrc_destroy(struct kref *ref); /** -- 2.43.0