Re: [PATCH 2/3] drm/xe/xe_oa: Avoid checking and setting fields in the OA report

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro `oa_report_header_64bit` becomes unused and is left as dead code.
--

--- Patch [2]: [PATCH 2/3] drm/xe/xe_oa: Avoid checking and setting fields in the OA report ---
commit 834ec77b5bb816bced6887fd353db954dc30486c
Author: Umesh Nerlige Ramappa <[email protected]>

drm/xe/xe_oa: Avoid checking and setting fields in the OA report

This commit removes the workaround that checked and cleared specific fields
in the OA report buffer, as reports can now land out of order. Future patches
will introduce new logic to handle updated reports.

> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index 2e4a89ebf737a..020b27c642268 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -216,42 +216,6 @@ static u32 xe_oa_hw_tail_read(struct xe_oa_stream *stream)
>  #define oa_report_header_64bit(__s) \
>  	((__s)->oa_buffer.format->header == HDR_64_BIT)

[Severity: Low]
This isn't a bug, but since oa_report_id(), oa_report_id_clear(),
oa_timestamp(), and oa_timestamp_clear() were removed by this patch, does
this leave the oa_report_header_64bit() macro unused?

> -static u64 oa_report_id(struct xe_oa_stream *stream, u32 report_offset)
> -{
> -	struct iosys_map *map = &stream->oa_buffer.bo->vmap;
> -
> -	return oa_report_header_64bit(stream) ?
> -		xe_map_rd(stream->oa->xe, map, report_offset, u64) :
> -		xe_map_rd(stream->oa->xe, map, report_offset, u32);
> -}

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2