Re: [PATCH 2/3] drm/xe/xe_oa: Avoid checking and setting fields in the OA report

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The macro `oa_report_header_64bit` is left defined but is completely unused after its only callers were removed.
--

--- Patch [2]: [PATCH 2/3] drm/xe/xe_oa: Avoid checking and setting fields in the OA report ---
commit 9f3ae8f0c5df0b654cf91ffc53ef86db9e3704fb
Author: Umesh Nerlige Ramappa <[email protected]>

drm/xe/xe_oa: Avoid checking and setting fields in the OA report

This commit removes the workarounds that check and set fields in the OA
report to determine if it has landed in memory. It removes several helper
functions that read and clear these fields because parts of the report may
land out of order under heavy workloads.

> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index 2e4a89ebf737a..020b27c642268 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -216,42 +216,6 @@ static u32 xe_oa_hw_tail_read(struct xe_oa_stream *stream)
>  #define oa_report_header_64bit(__s) \
>  	((__s)->oa_buffer.format->header == HDR_64_BIT)
>  

[Severity: Low]
Is this macro still needed? It looks like its only callers (oa_report_id, 
oa_report_id_clear, oa_timestamp, and oa_timestamp_clear) were removed by 
this patch, leaving this definition as dead code.

> -static u64 oa_report_id(struct xe_oa_stream *stream, u32 report_offset)
> -{
> -	struct iosys_map *map = &stream->oa_buffer.bo->vmap;
> -
> -	return oa_report_header_64bit(stream) ?
> -		xe_map_rd(stream->oa->xe, map, report_offset, u64) :
> -		xe_map_rd(stream->oa->xe, map, report_offset, u32);
> -}

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2