Re: [PATCH v2 0/3] drm/nouveau: Fix WARN_ON() from missing blend modes
[email protected] Tue, 21 Jul 2026 16:08:46 -0400
| Newsgroups | org.freedesktop.lists.nouveau,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
I had thought that testing this on fbcon would be enough, but there is still more issues with this series I found when adding these to the kernel I dog food on my desktop. Will figure them out and send another respin of this series asap On Mon, 2026-07-20 at 16:43 -0400, Lyude Paul wrote: > Recently a change went into the kernel to ensure that drivers which > expose color formats which have alpha channels. This would cause > nouveau > to hit a WARN_ON when setting up cursors, since they do support > blending > - but we never bothered trying to hook up the controls for it to > nouveau. >=20 > This fixes the issue by ensuring that nouveau always exposes a blend > mode for any planes with alpha channels, regardless of whether or not > we > have control of the blend mode hooked up. If someone wants to add > control for this in the future as well, it should be fairly easy to > hook > up with this. >=20 > Previous version: > =09https://patchwork.freedesktop.org/patch/741031/ >=20 > Lyude Paul (3): > =C2=A0 drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_func > =C2=A0 drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state() > =C2=A0 drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for > =C2=A0=C2=A0=C2=A0 wndws >=20 > =C2=A0drivers/gpu/drm/nouveau/dispnv50/curs507a.c |=C2=A0 3 ++ > =C2=A0drivers/gpu/drm/nouveau/dispnv50/disp.c=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0 4 +++ > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndw.c=C2=A0=C2=A0=C2=A0=C2=A0 | 4= 0 +++++++++++++++++-- > -- > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndw.h=C2=A0=C2=A0=C2=A0=C2=A0 | 1= 1 ++++++ > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c |=C2=A0 1 + > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndwc57e.c |=C2=A0 1 + > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndwc67e.c |=C2=A0 1 + > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndwca7e.c |=C2=A0 1 + > =C2=A08 files changed, 55 insertions(+), 7 deletions(-) >=20 >=20 > base-commit: b0a652436b892eb9a036a031b33099dca036faaa