Re: [PATCH 2/3] lib/xzembed/xz_dec_stream: Replace grub_memcpy() call with memcpy()

Andrew Hamilton <[email protected]>
Newsgroups org.gnu.grub-devel
Message-ID <CA+04=DaAdBy5Y5r2BTHJDCpBvZw5X5ymkjEj7jSmb4tbcDP_xw@mail.gmail.com>
Looks good to me, thank you.

Reviewed-by: Andrew Hamilton <[email protected]>


On Fri, Oct 24, 2025 at 3:58 PM Daniel Kiper via Grub-devel
<[email protected]> wrote:
>
> Make the code consistent.
>
> Signed-off-by: Daniel Kiper <[email protected]>
> ---
>  grub-core/lib/xzembed/xz_dec_stream.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/grub-core/lib/xzembed/xz_dec_stream.c b/grub-core/lib/xzembed/xz_dec_stream.c
> index f2dd42dc2..13658d448 100644
> --- a/grub-core/lib/xzembed/xz_dec_stream.c
> +++ b/grub-core/lib/xzembed/xz_dec_stream.c
> @@ -387,8 +387,7 @@ static enum xz_ret hash_validate(struct xz_dec *s, struct xz_buf *b,
>                 && sizeof (s->hash_value) >= hash->mdlen)
>         {
>                 hash->final(hash_context);
> -               grub_memcpy (s->hash_value, hash->read(hash_context),
> -                            hash->mdlen);
> +               memcpy (s->hash_value, hash->read (hash_context), hash->mdlen);
>                 s->have_hash_value = 1;
>                 if (s->hash_id == 1 || crc32)
>                 {
> --
> 2.11.0
>
>
> _______________________________________________
> Grub-devel mailing list
> [email protected]
> https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.