Re: [PATCH 3/3] build: Add appended signatures header file to EXTRA_DIST

I did some more investigation on these and found the following:

grub-core/commands/tpm2_key_protector/tpm2key.asn
   - Seems only required if manually regenerating file
grub-core/commands/tpm2_key_protector/tpm2key_asn1_tab.c but may be
helpful to include for reference or if someone wants to change it for
some reason. I will send a patch to include it.

grub-core/lib/libgcrypt-grub/mpi: ec.c
grub-core/lib/libgcrypt-grub/mpi: ec-ed25519.c
grub-core/lib/libgcrypt-grub/mpi: ec-hw-s390x.c
grub-core/lib/libgcrypt-grub/mpi: ec-nist.c
grub-core/lib/libgcrypt-grub/src: context.c
grub-core/lib/libgcrypt-grub/src: gen-note-integrity.sh
grub-core/lib/libgcrypt-grub/src: hwf-arm.c
grub-core/lib/libgcrypt-grub/src: hwf-ppc.c
grub-core/lib/libgcrypt-grub/src: hwf-s390x.c
grub-core/lib/libgcrypt-grub/src: hwf-x86.c
grub-core/lib/libgcrypt-grub/src: mpicalc.c
  - These don't seem to be needed in the dist archive, building from
git source and dist results in the same output either way.
grub-core/tests: cmdline_cat_test.c
grub-core/tests: gfxterm_menu.c
 - These tests are disabled so make sense they aren't included.

MAINTAINERS
SECURITY
 - These may be worth including, I'll submit a patch that adds them
for consideration.
.travis.yml
 - I guess this was intended for a CI process but may not be actually
used anywhere currently.

I also found the new zstd test files need to be added so will send a
patch for those too.

In summary, this looks good to me, I'll send a patch for other possible updates.

Reviewed-by: Andrew Hamilton <[email protected]>

Thanks,
Andrew



On Fri, Oct 24, 2025 at 5:50 PM Andrew Hamilton <[email protected]> wrote:
>
> Hello,
>
> I notice that these files aren't in the dist archive currently, should
> they be added too?
>
> grub-core/commands/tpm2_key_protector/tpm2key.asn
> grub-core/lib/libgcrypt-grub/mpi: ec.c
> grub-core/lib/libgcrypt-grub/mpi: ec-ed25519.c
> grub-core/lib/libgcrypt-grub/mpi: ec-hw-s390x.c
> grub-core/lib/libgcrypt-grub/mpi: ec-nist.c
> grub-core/lib/libgcrypt-grub/src: context.c
> grub-core/lib/libgcrypt-grub/src: gen-note-integrity.sh
> grub-core/lib/libgcrypt-grub/src: hwf-arm.c
> grub-core/lib/libgcrypt-grub/src: hwf-ppc.c
> grub-core/lib/libgcrypt-grub/src: hwf-s390x.c
> grub-core/lib/libgcrypt-grub/src: hwf-x86.c
> grub-core/lib/libgcrypt-grub/src: mpicalc.c
> grub-core/tests: cmdline_cat_test.c
> grub-core/tests: gfxterm_menu.c
>
> These I wasn't sure if it was intentional to leave them out?
> MAINTAINERS
> SECURITY
> .travis.yml
>
> Thanks,
> Andrew
>
> On Fri, Oct 24, 2025 at 3:58 PM Daniel Kiper via Grub-devel
> <[email protected]> wrote:
> >
> > This file was not added to EXTRA_DIST during the appended signatures merge.
> >
> > Fixes: 3e4ff6ffb (appended signatures: Parse ASN1 node)
> >
> > Signed-off-by: Daniel Kiper <[email protected]>
> > ---
> >  conf/Makefile.extra-dist | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/conf/Makefile.extra-dist b/conf/Makefile.extra-dist
> > index 846d45341..dcb0bed07 100644
> > --- a/conf/Makefile.extra-dist
> > +++ b/conf/Makefile.extra-dist
> > @@ -76,6 +76,8 @@ EXTRA_DIST += grub-core/tests/asn1/asn1_test.h
> >  EXTRA_DIST += $(shell find $(top_srcdir)/grub-core/tests/asn1/tests -name '*.h')
> >  EXTRA_DIST += $(shell find $(top_srcdir)/grub-core/commands/tpm2_key_protector -name '*.h')
> >
> > +EXTRA_DIST += grub-core/commands/appendedsig/appendedsig.h
> > +
> >  EXTRA_DIST += grub-core/lib/LzmaDec.c
> >
> >  EXTRA_DIST += grub-core/fs/cpio_common.c
> > --
> > 2.11.0
> >
> >
> > _______________________________________________
> > Grub-devel mailing list
> > [email protected]
> > https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel