Re: [PATCH 0/3] tests: improvements and fixes for the test suite

On Fri, Sep 19, 2025 at 03:45:02PM -0600, Leo Sandoval via Grub-devel wrote:
> With the goal to have a all-pass 'make check', these patches improve a bit
> tests, increasing bash verbosity and skipping those where tools are not available.
> Finally it removes the -w parameter on the mkfs.hfsplus.
>
> Taking into account Andrew's series [1] and this series, I am still seeing
> 1 failure and 3 errors as shown below. So this work is no over but exposing
> these may lead to further fixes.
>
> Finally, all these tests were done on a Fedora 42 VM. If containers are used
> like those at [2], I am seeing a bunch of errors due to the lack of the
> /dev/loop0 device but I will update the corresponding thread.
>
> [1] https://lists.nongnu.org/archive/html/grub-devel/2025-08/msg00249.html
> [2] https://lists.gnu.org/archive/html/grub-devel/2025-06/msg00139.html
>
>     =================================
>     GRUB 2.13: ./test-suite.log
>     =================================
>
>     # TOTAL: 89
>     # PASS:  80
>     # SKIP:  5
>     # XFAIL: 0
>     # FAIL:  1
>     # XPASS: 0
>     # ERROR: 3
>
>
>     FAIL: zfs_test
>     ==============
>
>     + '[' x0 = x ']'
>     + '[' 0 '!=' 0 ']'
>     + which zpool
>     + ./grub-fs-tester zfs
>     Defaulting to 4K blocksize (ashift=12) for '/dev/loop0'
>     1024+0 records in
>     1024+0 records out
>     1048576 bytes (1.0 MB, 1.0 MiB) copied, 0.0128335 s, 81.7 MB/s
>     Device proc: Filesystem type procfs - Sector size 512B - Total size 0KiB
>     Device loop0: Filesystem type zfs - Label `grub_testieufiue r' - Last modification time 2025-09-19 19:30:17 Friday, UUID aeaca1e49e9167be - Sector size 512B - Total size 5939200KiB
>     Device host: Filesystem type hostfs - Sector size 512B - Total size 0KiB
>     TIME FAIL
>     DIR          20250919193013 sdir/
>     DIR          20250919193013 0/
>     5242879      20250919193013 1.img
>     5242879      20250919193013 .?*\!"#%@$%&'()+ ,-.:;<=>^{_}[]`|~.
>     5242879      20250919193013 éàèüöäëñкирилица莭莽茝Ελληνικά
>     5242879      20250919193013 qwertzuiopasdfghjklyxcvbnm1234567890qwertzuiopasdfghjklyxcvbnm1234567890oiewqfiewioqoiqoiurqruewqoiuwoieoiiuewqroreqiufieiuwrnureweriuvceoiroiewqoiricdsalkcndsakfirefoiwqeoircorejwoij\
>     freoijojoiewjfwnfcoirenfoirefnreoifenoiwfnoi
>     5242879      20250919193013 CaSe
>     5242879      20250919193013 cAsE
>     1048576      20250919193013 american-english
>     5242879      20250919193013 sym
>     ???????????? 20250919193013 longsym
>     ???????????? 20250919193013 psym
>     5242879      20250919193013 Ελληνικάкирилица éàèüöäëñ莭莽茝
>     5242879      20250919193013 hard
>     total 25
>     drwxr-xr-x. 4 root root 16 Sep 19 19:30 grub fs
>     NAME                 SIZE  ALLOC   FREE    CAP  DEDUP  HEALTH  ALTROOT
>     grub_testieufiue r  5.66G  43.8M  5.61G     0%  1.00x  ONLINE  /tmp/grub-fs-tester.20250919213012734622369.zfs.ztl/zfs_ro
>     FAIL zfs_test (exit status: 1)
>
>
>     ERROR: nilfs2_test
>     ==================
>
>     + '[' x0 = x ']'
>     + '[' 0 '!=' 0 ']'
>     + which mkfs.nilfs2
>     + ./grub-fs-tester nilfs2
>     mount.nilfs2: preparing failed: No such device
>     MOUNT FAILED.
>     ERROR nilfs2_test (exit status: 99)
>
>     ERROR: exfat_test
>     =================
>
>     + '[' x0 = x ']'
>     + '[' 0 '!=' 0 ']'
>     + which mkfs.exfat
>     + ./grub-fs-tester exfat
>     exfatprogs version : 1.2.8
>     Creating exFAT filesystem(/dev/loop0, cluster size=512)
>
>     Writing volume boot record: done
>     Writing backup volume boot record: done
>     Fat table creation: done
>     Allocation bitmap creation: done
>     Upcase table creation: done
>     Writing root directory entry: done
>     Synchronizing...
>
>     exFAT format complete!
>     mount: /tmp/grub-fs-tester.20250919212812088905104.exfat.WLh/exfat_rw: unknown filesystem type 'exfat-fuse'.
>            dmesg(1) may have more information after failed mount system call.
>     MOUNT FAILED.
>     ERROR exfat_test (exit status: 99)
>
>     ERROR: zfs_zstd_test
>     ====================
>
>     zfs zstd compression not supported; cannot test zfs zstd.
>     ERROR zfs_zstd_test (exit status: 99)
>
>
> Leo Sandoval (3):
>   tests: skip tests if required tools are not available
>   tests: include verbosity on tests.in checks
>   tests: remove -w param from mkfs.hfsplus

For all patches Reviewed-by: Daniel Kiper <[email protected]>...

Daniel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel