[PATCH v3 1/4] tests/erofs_test: Fix mkfs.erofs version test to not use process substitution bashism
Glenn Washburn <[email protected]>
| Newsgroups | org.gnu.grub-devel |
|---|---|
| Message-ID | <1126cf87cc17326908e6432b6640af63bb60f32b.1763003164.git.development@efficientek.com> |
The shell used to run the tests is generally /bin/sh, which does not support process substitution. Fixes: b990df0bef9e (tests/util/grub-fs-tester: Fix EROFS label tests in grub-fs-tester) Signed-off-by: Glenn Washburn <[email protected]> --- tests/util/grub-fs-tester.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index 126f19a7e882..f29436d927dc 100644 --- a/tests/util/grub-fs-tester.in +++ b/tests/util/grub-fs-tester.in @@ -596,11 +596,12 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do | x"minix3" | xreiserfs_old) NOFSLABEL=y;; x"erofs_"*) - MKFS_EROFS_VERSION=$(mkfs.erofs -V 2>/dev/null | tr ' ' '\n' | grep '^[0-9]') + MKFS_EROFS_VERSION=$(mkfs.erofs 2>/dev/null | head -n 1 | (read _ V; echo $V)) # check if the version is at least 1.6 - if [ $(sort -V <(echo "$MKFS_EROFS_VERSION") <(echo "1.6") | head -n 1) != "1.6" ]; then + if [ "$(echo -e "${MKFS_EROFS_VERSION}\n1.6" | sort -V | head -n 1)" != "1.6" ]; then NOFSLABEL=y - fi + unset FSLABEL + fi;; esac PDIRCOMPNUM=210 -- 2.34.1 _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel