Re: [PATCH 1/2] tests/grub_cmd_cryptomount: Expect test success, now that GRUB supports Argon2

> On 17 Nov 2025, at 12:10 PM, Glenn Washburn <[email protected]> wrote:
> 
> This test was included to verify that, while GRUB did not have Argon2
> support, trying to open a LUKS2 volume with an Argon2 keyslot would fail
> Now that Argon2 support is included, the test is failing because it
> expected a failure, but is now getting success. Change the test to expect
> success.
> 
> Signed-off-by: Glenn Washburn <[email protected]>

Reviewed-by: Sudhakar Kuppusamy <[email protected]>

Thanks,
Sudhakar  
> ---
> tests/grub_cmd_cryptomount.in | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/grub_cmd_cryptomount.in b/tests/grub_cmd_cryptomount.in
> index eaa187efad0a..a4fababa0a80 100644
> --- a/tests/grub_cmd_cryptomount.in
> +++ b/tests/grub_cmd_cryptomount.in
> @@ -178,8 +178,7 @@ eval testcase "'LUKS2 test with different metadata size:'" \
>     @builddir@/grub-shell-luks-tester $LUKS2_COMMON_OPTS $COMMON_OPTS \
>         "--cs-opts='--luks2-metadata-size 512k'"
> 
> -# TODO: Expect a failure with LUKS2 volumes with argon2 key derivation
> -eval testcase_fail "'LUKS2 test with argon2 pbkdf:'" \
> +eval testcase "'LUKS2 test with argon2 pbkdf:'" \
>     @builddir@/grub-shell-luks-tester --luks=2 $COMMON_OPTS \
>         "--cs-opts='--pbkdf-memory 32'" "--cs-opts='--pbkdf-parallel 1'"
> 
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> Grub-devel mailing list
> [email protected]
> https://lists.gnu.org/mailman/listinfo/grub-devel


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel