Re: GRUB MR status at freedesktop: Reviewed-by and Tested-by not yet on merge commits
Leo Sandoval via Grub-devel <[email protected]> Mon, 20 Apr 2026 15:08:17 -0600
| Newsgroups | org.gnu.grub-devel |
|---|---|
| Message-ID | <CACF7NTiS7p2sWiakTE86ZN9E93twVbj=y8n5FqYb7imp6U-WeQ@mail.gmail.com> |
--===============1630097435119595907== Content-Type: multipart/alternative; boundary="00000000000040d3bf064feab36d" --00000000000040d3bf064feab36d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable If you have pending MRs to be merged, please manually add the corresponding Git commit trailers to your commit descriptions for the moment. The marge-bot, which in theory would handle these additions based on approver data, isn't ready yet. I'll keep you updated if anything changes. Leo On Mon, Apr 13, 2026 at 1:57=E2=80=AFPM Leo Sandoval <[email protected]> = wrote: > As you may have noticed, several MRs have been merged but several others > are still pending. MR merge rate has been delayed because we are still > working to include Git commit trailers, such as `Reviewed-by:` and > `Tested-by:`. Including this metadata in every merge commit is quite > important as you know. BTW, The `Signed-off` is now part of the CI, so if > it's missing, the MR's pipeline will fail soon. > > Fortunately on fdo (freedesktop) there is a bot (marge-bot) that can help > us include this data, but it is still not fully working as expected. You > can see the latest status at [1]. > > If you know of a better way to, please include your feedback at [1]. > > Leo > > [1] https://gitlab.freedesktop.org/gnu-grub/grub/-/work_items/3 > --00000000000040d3bf064feab36d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>If you have pending MRs to be merged, please manually= =C2=A0add the corresponding Git commit trailers to your commit descriptions= for the moment.</div><div><br></div><div>The marge-bot, which in theory wo= uld handle these additions based on approver data,=C2=A0 isn't ready ye= t. I'll keep you updated if anything changes.</div><div><br></div><div>= Leo</div><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote gmail_quo= te_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Apr 13, 2026 at= 1:57=E2=80=AFPM Leo Sandoval <<a href=3D"mailto:[email protected]">ls= [email protected]</a>> wrote:<br></div><blockquote class=3D"gmail_quote"= style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p= adding-left:1ex"><div dir=3D"ltr">As you may have noticed, several MRs have= been merged but several others are still pending. MR merge rate has been d= elayed because we are still working to include Git commit trailers, such as= `Reviewed-by:` and `Tested-by:`. Including this metadata in every merge co= mmit is quite important as you know.=C2=A0BTW, The `Signed-off` is now part= of the CI, so if it's missing, the MR's pipeline will fail soon.<b= r><br>Fortunately on fdo (freedesktop) there is a bot (marge-bot) that can = help us include this data, but it is still not fully working as expected. Y= ou can see the latest status at [1].<br><br>If you know of a better way to,= please include your feedback at [1].<div><br></div><div>Leo<br><br>[1] <a = href=3D"https://gitlab.freedesktop.org/gnu-grub/grub/-/work_items/3" target= =3D"_blank">https://gitlab.freedesktop.org/gnu-grub/grub/-/work_items/3</a>= </div></div> </blockquote></div></div> --00000000000040d3bf064feab36d-- --===============1630097435119595907== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3J1Yi1kZXZl bCBtYWlsaW5nIGxpc3QKR3J1Yi1kZXZlbEBnbnUub3JnCmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL2dydWItZGV2ZWwK --===============1630097435119595907==--