Re: [PATCH v3 2/3] ath10k: Introduce a device-tree quirk to skip host cap QMI requests

On 25/03/2026 18:15, Dmitry Baryshkov wrote:
> On Wed, Mar 25, 2026 at 05:41:13PM +0100, David Heidelberg via B4 Relay wrote:
>> From: Amit Pundir <[email protected]>
>>
>> There are firmware versions which do not support host capability QMI
>> request. We suspect either the host cap is not implemented or there may
>> be firmware specific issues, but apparently there seem to be a generation
>> of firmware that has this particular behavior.
> 
> It needs to be explicit that this happens _before_ firmware-N.bin and
> board-M.bin loading. As such, you can't add a quirk to the firmware.bin
> (a standard way to handle firmware issues).

Ok, let me send with updated desc :)

> 
>> For example, firmware build on Xiaomi Poco F1 (sdm845) phone:
>> "QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c3-00257-QCAHLSWMTPLZ-1"
>>
>> If we do not skip the host cap QMI request on Poco F1, then we get a
>> QMI_ERR_MALFORMED_MSG_V01 error message before loading the firmware in the
>> ath10k_qmi_host_cap_send_sync(). This error message is not fatal to the
>> firmware nor to the ath10k driver and we can still bring up the WiFi
>> services successfully if we just ignore it.
>>
>> Hence introducing this device-tree quirk to skip host capability
>> QMI request for the devices with firmware versions which do not support
>> this feature.
>>
>> Suggested-by: Bjorn Andersson <[email protected]>
>> Signed-off-by: Amit Pundir <[email protected]>
> 
> You are sending the patch, but it misses your SoB.

Oh, sorry bout that.

checkpatch.pl could spot this kind of an issue :P

David>
>> ---
>>   drivers/net/wireless/ath/ath10k/qmi.c  | 13 ++++++++++---
>>   drivers/net/wireless/ath/ath10k/snoc.c |  3 +++
>>   drivers/net/wireless/ath/ath10k/snoc.h |  1 +
>>   3 files changed, 14 insertions(+), 3 deletions(-)
> 

-- 
David Heidelberg