Re: [PATCH RFC v2] wifi: ath10k: make in-order rx amsdu buffers persistent

On 31/07/2026 16:39, Richard Acayan wrote:
[...]

>>>   
>>> +	msdu = skb_peek(list);
>>> +	rxd = HTT_RX_BUF_TO_RX_DESC(hw,
>>> +				    (void *)msdu->data - hw->rx_desc_ops->rx_desc_size);
>>
>> Dead rxd computation before the loop — VALID, MINOR
>>
>> Lines 3168–3170 compute rxd via skb_peek(), but the while loop at 3172
>> immediately dequeues the same SKB and unconditionally recomputes rxd at lines
>> 3175–3177. The pre-loop assignment is never read. It's dead code. The original
>> patch must have introduced this when restructuring (the pre-existing code
>> likely used rxd from before the loop). It should be removed.
> 
> This was removed on 20 January 2026 before v1 was submitted. It seems
> this v2 is based on applying the commits to the pre-2026 patch.

I checked against what Comma.AI uses, and it's also gone there, so we've been 
using pre-v1 in sdm845-next.

Dropping it definitely make sense, and since Comma.AI already tested, I assume 
no regression.

Will be addressed in v3.

David