Re: [PATCH v5 4/4] wifi: ath12k: implement custom wake_tx_queue with flow control

On 8/11/2026 4:14 AM, Jose Ignacio Tornos Martinez wrote:
>>> +		spin_lock(&tcl_ring->lock);
>>
>> seems this should be spin_lock_bh() to align with all other callers in the driver.
> 
> The outer spin_lock_bh(&tx_ring->wake_tx_lock); already disables BH, so
> spin_lock() for the inner tcl_ring->lock is correct and sufficient. Using
> spin_lock_bh() would redundantly disable BH again.

Yes, but if that outer spinlock is ever removed, the inner spinlock would no
longer be correct. So the defensive pattern is to use _bh in both places, and
both of my AI review agents concur with this practice.

/jeff