Re: [PATCH] wifi: ath11k: fix NULL derefence in ath11k_qmi_m3_load()
Jeff Johnson <[email protected]>
| Newsgroups | org.infradead.lists.ath11k,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On 9/17/2025 12:20 PM, Matvey Kovalev wrote:
> If ab->fw.m3_data points to data, then fw pointer remains null.
> Further, if m3_mem is not allocated, then fw is dereferenced to be
> passed to ath11k_err function.
>
> Replace fw->size by m3_len.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 7db88b962f06 ("wifi: ath11k: add firmware-2.bin support")
> Cc: [email protected]
> Signed-off-by: Matvey Kovalev <[email protected]>
> ---
> drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
> index 378ac96b861b7..1a42b4abe7168 100644
> --- a/drivers/net/wireless/ath/ath11k/qmi.c
> +++ b/drivers/net/wireless/ath/ath11k/qmi.c
> @@ -2557,7 +2557,7 @@ static int ath11k_qmi_m3_load(struct ath11k_base *ab)
> GFP_KERNEL);
> if (!m3_mem->vaddr) {
> ath11k_err(ab, "failed to allocate memory for M3 with size %zu\n",
> - fw->size);
> + m3_len);
> ret = -ENOMEM;
> goto out;
> }
I'll fix this subject misspelling:
WARNING:TYPO_SPELLING: 'derefence' may be misspelled - perhaps 'dereference'?
/jeff