Re: [PATCH ath-current] wifi: ath11k: avoid bit operation on key flags
Jeff Johnson <[email protected]>
| Newsgroups | org.infradead.lists.ath11k,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 03 Oct 2025 14:51:58 +0530, Rameshkumar Sundaram wrote:
> Bitwise operations with WMI_KEY_PAIRWISE (defined as 0) are ineffective
> and misleading. This results in pairwise key validations added in
> commit 97acb0259cc9 ("wifi: ath11k: fix group data packet drops
> during rekey") to always evaluate false and clear key commands for
> pairwise keys are not honored.
>
> Since firmware supports overwriting the new key without explicitly
> clearing the previous one, there is no visible impact currently.
> However, to restore consistency with the previous behavior and improve
> clarity, replace bitwise operations with direct assignments and
> comparisons for key flags.
>
> [...]
Applied, thanks!
[1/1] wifi: ath11k: avoid bit operation on key flags
commit: 9c78e747dd4fee6c36fcc926212e20032055cf9d
Best regards,
--
Jeff Johnson <[email protected]>