Re: [PATCH] wifi: ath11k: Add quirk entry for Thinkpad T14s Gen3 AMD

On Mon, Nov 24, 2025, at 10:32 AM, Takashi Iwai wrote:
> On Mon, 24 Nov 2025 16:13:05 +0100,
> Mark Pearson wrote:
>> 
>> Thanks Takashi-san,
>> 
>> On Mon, Nov 24, 2025, at 8:47 AM, Takashi Iwai wrote:
>> > The recent kernels showed a regression wrt suspend/resume on Lenovo
>> > Thinkpad T14s Gen 3 AMD model; it fails to reconnect on resume after a
>> > long time sleep.  The only workaround was to unload/reload the driver
>> > (or reboot).
>> >
>> > It seems that this model also requires the similar quirk with
>> > ATH11K_PM_WOW which has been done for other Thinkpad models.
>> >
>> > Link: https://bugzilla.suse.com/show_bug.cgi?id=1254181
>> > Signed-off-by: Takashi Iwai <[email protected]>
>> > ---
>> >
>> > I'm not sure whether this model has another DMI entry, so put Mark to
>> > Cc.
>> >
>> > Also, I wonder which Thinkpad models are rather the ones that should
>> > *not* take the quirk.  Since mine is Gen 3 and I already see Gen 2
>> > entries, which else remaining...?
>> >
>> 
>> It should only apply to models with the ath11k modem - but it looks like Gen 2 up to Gen 6....which is quite a lot. I don't know if all of those are impacted.
>> I think we'll have to do more testing and get feedback from the FW team, which will take a bit I'm afraid. I'll look into it.
>
> I see, thanks for confirmation!
>
>> >
>> >  drivers/net/wireless/ath/ath11k/core.c | 7 +++++++
>> >  1 file changed, 7 insertions(+)
>> >
>> > diff --git a/drivers/net/wireless/ath/ath11k/core.c 
>> > b/drivers/net/wireless/ath/ath11k/core.c
>> > index 812686173ac8..3aa78a39394b 100644
>> > --- a/drivers/net/wireless/ath/ath11k/core.c
>> > +++ b/drivers/net/wireless/ath/ath11k/core.c
>> > @@ -924,6 +924,13 @@ static const struct dmi_system_id 
>> > ath11k_pm_quirk_table[] = {
>> >  			DMI_MATCH(DMI_PRODUCT_NAME, "21J4"),
>> >  		},
>> >  	},
>> > +	{
>> > +		.driver_data = (void *)ATH11K_PM_WOW,
>> > +		.matches = { /* T14s G3 AMD */
>> > +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> > +			DMI_MATCH(DMI_PRODUCT_NAME, "21CR"),
>> > +		},
>> > +	},
>> >  	{
>> >  		.driver_data = (void *)ATH11K_PM_WOW,
>> >  		.matches = { /* T14 G4 AMD #1 */
>> > -- 
>> > 2.52.0
>> 
>> I think you need to add the "21CQ" Product Name for this platform too (every model has two IDs depending on where in the world it is deployed)
>> 
>> Unfortunately my T14s G3 AMD seems to be dead :( I can't test and confirm directly.
>
> OK, I can resubmit with 21CQ entry later.
>
> Also, maybe it'd be worth for adding a module option to specify /
> override the quirk, so that one can test without recompiling the
> kernel?
>
Yeah - that could be useful so users can confirm if they need the quirk too (especially if platforms outside of the Linux program are impacted). It gets my vote :)

Mark