Re: [PATCH ath-next v5 0/6] wifi: ath11k: Add single shot/periodic CFR capture support

On 12/30/2025 4:25 PM, Qian Zhang wrote:
> To enable/disable cfr feature use command,
> 
> echo <val> > /sys/kernel/debug/ieee80211/phyX/ath11k/enable_cfr
> 
> where, val: 0 to disable CFR and 1 to enable CFR.
> 
> To enable CFR capture for associated peers,
> 
> echo "<val> <bw> <periodicity> <method>"
>  >
> /sys/kernel/debug/ieee80211/phyX/netdev\:wlanx/stations/<mac>/cfr_capture
> 
> val: 0 - stop CFR capture
>      1 - start CFR capture
> bw: CFR capture bandwidth
>      0 - 20MHZ
>      1 - 40MHZ
>      2 - 80MHZ
> Periodicity: Periodicity at which hardware is expceted to collect CFR
> dump.
>      0 - single shot capture.
>      non zero - for Periodic captures (value should be multiple of 10
> ms)
> method: Method used by hardware to collect the CFR dump.
>      0 - from the ACKs of QOS NULL packets.
> 
> To enable CFR capture for unassociated clients,
> 
> echo "<mac address> <val> <periodicity>"
>  > /sys/kernel/debug/ieee80211/phyX/ath11k/cfr_unassoc
> 
> Mac address: mac address of the client.
> Val: 0 - start CFR capture
>      1 - stop CFR capture
> Periodicity: Periodicity at which hardware is expceted to collect CFR
> dump.
>      0 - single shot capture.
>      non zero - for Periodic captures (value should be multiple of 10
> ms)
> 
> To collect the cfr dump,
> cat /sys/kernel/debug/ieee80211/phy0/ath11k/cfr_capture0 > /tmp/cfr.bin
> 
> Previous link:
> https://lore.kernel.org/all/[email protected]/
> 
> Signed-off-by: Yu Zhang(Yuriy) <[email protected]>
> Signed-off-by: Qian Zhang <[email protected]>
> 
> ---
> Changes in v5:
>  - Restore the author in all patch commit messages.
>  - Update patch 6/6. Cache the phymode during association and
>    use it to replace phymode reported by the firmware.
> Changes in v4:
>  - Update patch 2/6. Remove redundant bw parameter check in
>    ath11k_dbg_sta_write_cfr_capture()
> Changes in v3:
>  - Update related comments.
> Changes in v2:
>  - Update related comments.
> ---
> 
> Venkateswara Naralasetty (6):
>   wifi: ath11k: Add initialization and deinitialization sequence for CFR
>     module
>   wifi: ath11k: Register debugfs for CFR configuration
>   wifi: ath11k: Add support unassociated client CFR
>   wifi: ath11k: Register relayfs entries for CFR dump
>   wifi: ath11k: Register DBR event handler for CFR data
>   wifi: ath11k: Register handler for CFR capture event
> 
>  drivers/net/wireless/ath/ath11k/Kconfig       |   11 +
>  drivers/net/wireless/ath/ath11k/Makefile      |    1 +
>  drivers/net/wireless/ath/ath11k/cfr.c         | 1022 +++++++++++++++++
>  drivers/net/wireless/ath/ath11k/cfr.h         |  308 +++++
>  drivers/net/wireless/ath/ath11k/core.c        |   41 +-
>  drivers/net/wireless/ath/ath11k/core.h        |   19 +-
>  drivers/net/wireless/ath/ath11k/dbring.c      |   50 +-
>  drivers/net/wireless/ath/ath11k/dbring.h      |    8 +-
>  drivers/net/wireless/ath/ath11k/debug.h       |    8 +-
>  drivers/net/wireless/ath/ath11k/debugfs_sta.c |  142 ++-
>  drivers/net/wireless/ath/ath11k/hal.c         |    3 +-
>  drivers/net/wireless/ath/ath11k/hw.h          |    5 +-
>  drivers/net/wireless/ath/ath11k/mac.c         |   19 +-
>  drivers/net/wireless/ath/ath11k/wmi.c         |  147 ++-
>  drivers/net/wireless/ath/ath11k/wmi.h         |   97 +-
>  15 files changed, 1855 insertions(+), 26 deletions(-)
>  create mode 100644 drivers/net/wireless/ath/ath11k/cfr.c
>  create mode 100644 drivers/net/wireless/ath/ath11k/cfr.h
> 
> 
> base-commit: 4465d808fda12fa47f83733a9f7b7dbc29d0ea54
> prerequisite-patch-id: f44bdcbd36af0c3fd57b477848bf4699cade9389
> prerequisite-patch-id: 76c61f8f00aac2a3b9ff31e0166bb12997c2b0cf
> prerequisite-patch-id: 886b24b2496167c304e8ed42b5d879e0ecab111c
> prerequisite-patch-id: 672baf608620c531b3765941c2719ad9d34b99c1
> prerequisite-patch-id: 07c9ff6fcaf4ba464be993caa19eb49113eedbdf

what are these dependencies? They are not present in old revisions.

BTW, if you indeed has dependencies, in addition to these prerequisite-patch-id's, please
also list them explicitly in the cover letter above.