Re: [PATCH ath-next v4 1/6] wifi: ath11k: Add initialization and deinitialization sequence for CFR module

Qian Zhang <[email protected]>
Newsgroups org.infradead.lists.ath11k,org.kernel.vger.linux-wireless
Message-ID <[email protected]>

On 12/31/2025 2:06 PM, Arend van Spriel wrote:
> Op 23 december 2025 10:27:46 schreef Qian Zhang 
> <[email protected]>:
> 
>> Channel Frequency Response (CFR) module will be initialized only when
>> the following criteria passes:
>> * Enabled CFR support for the hardware through the hardware param
>>   'cfr_support'
>> * WMI service enabled for the CFR support
>>   'WMI_TLV_SERVICE_CFR_CAPTURE_SUPPORT'
> 
> [...]
> 
>> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/ 
>> wireless/ath/ath11k/core.c
>> index 812686173ac8..6a6bf6316ac9 100644
>> --- a/drivers/net/wireless/ath/ath11k/core.c
>> +++ b/drivers/net/wireless/ath/ath11k/core.c
>> @@ -1,7 +1,6 @@
>> // SPDX-License-Identifier: BSD-3-Clause-Clear
>> /*
>>  * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
>> - * Copyright (c) 2021-2025 Qualcomm Innovation Center, Inc. All 
>> rights reserved.
> 
> Hi Qiang Zhang,
> 
> Some explanation on this would have been nice. Doing this in a separate 
> patch would be even better.
> 
> Regards,
> Arend

The CFR-related statistics are reported through a special hardware ring. 
The changes here are for configuring buffers for these rings. Currently, 
255 buffers of size 8200 have been prepared for CFR. For hardware that 
does not support this feature, both the number and size of buffers are 
zero.
Do you think the changes in core.c should be made as a separate patch?

Thanks,
Qian

>>  * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>>  */
> 
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.