Re: [PATCH v3] wifi: ath11k: move .max_tx_ring to struct ath11k_hw_hal_params
Jeff Johnson <[email protected]>
| Newsgroups | org.infradead.lists.ath11k,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On Sun, 28 Dec 2025 09:14:05 -0600, Alexandru Gagniuc wrote:
> ".max_tx_ring" is an upper bounds to indexing ".tcl2wbm_rbm_map". It
> is initialized in, core.c, a different file than the array. This
> spaghetti-like relation is fragile and not obvious. Accidentally
> setting ".max_tx_ring" too high leads to a hard to track out-of-
> bounds access and memory corruption.
>
> There is a small ambiguity on the meaning of "max_tx_ring":
> - The highest ring, max=3 implies there are 4 rings (0, 1, 2, 3)
> - The highest number to use for array indexing (there are 3 rings)
>
> [...]
Applied, thanks!
[1/1] wifi: ath11k: move .max_tx_ring to struct ath11k_hw_hal_params
commit: b515730ec3d231aa36b6177524532fc7d94f1750
Best regards,
--
Jeff Johnson <[email protected]>