Re: [PATCH ath-next] wifi: ath12k: skip MLO multicast links during crash recovery in Tx path
Baochen Qiang <[email protected]> Mon, 27 Jul 2026 10:40:55 +0800
| Newsgroups | org.infradead.lists.ath12k,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 7/23/2026 1:46 PM, Pavankumar Nandeshwar wrote: > In ath12k_wifi7_mac_op_tx(), the MLO multicast broadcast path iterates > over all active links and copies the original skb for transmission on > each link. When firmware crash recovery is underway (ATH12K_FLAG_CRASH_FLUSH > set), the per-link copy is allocated and partially processed before > ath12k_wifi7_dp_tx() eventually rejects it with -ESHUTDOWN. > > This wastes GFP_ATOMIC memory and produces spurious "failed to transmit > frame" warnings for every active MLO link during the recovery window. > The unicast and non-MLO paths are unaffected: they call ath12k_wifi7_dp_tx() > directly, which already guards against the flag at its entry. > > Skip any link whose associated ath12k_base has ATH12K_FLAG_CRASH_FLUSH set > before performing the skb_copy(), matching the behaviour of > ath12k_wifi7_dp_tx() but avoiding the unnecessary allocation entirely. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3 > > Signed-off-by: Pavankumar Nandeshwar <[email protected]> Reviewed-by: Baochen Qiang <[email protected]>